From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DFBD44607B for ; Wed, 30 Sep 2026 07:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790753271; cv=none; b=k505B6AIhpLkCLYY+Y65lQlGdyNpQEg6Kc4NQJqH1a8lW9eJUbVlXMrLhtfikodcgBnq0iWqafOuAp/1yaWYFsr7g9SYAXyoUi0CehYU1uuQHRc9HMCoJy8lM8RMYtn+eOCY7JDXsIJqN8piHfVljjqX3uZLl/lqHL5rG+K6I1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790753271; c=relaxed/simple; bh=9OsGp6MbSHvjE+muNEP4p1TUnXdoyedGt8UY6i3iUCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V7oguj1c3UasqOgpQarRsSk1u0NSoi38VQnmrFLe59kLw0eKYwUTnxmvYsChOzs7sSKEmvjjLkUg+il6LzY0b2V2sYcOlhwQ6LlZd+duyWTqs2GzCfxCOYZT+XbxqH1qgDFahI2vvtee2Gm10KWCaHqE0V6FhpQNd2/uziiFbmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AJhSbWsC; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AJhSbWsC" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e7bcb94d3so37486765e9.2 for ; Wed, 30 Sep 2026 00:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790753268; x=1791358068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WruczPkazS4ZUlcOrN4t2XFu86i7R3FFqgwfWNzE8vs=; b=AJhSbWsCUMpGeOPDm+Y0kftCfbUAgAd2uDxIB2s2J+FjswDQVvI2SEoHON5OJwBpOQ 3lhWZCLV8gK5FP3wDJUN8Xkx7ILsN2MWYCWa43DPGAQAUQeQkKd5uq2kRWjX+bzbpylp KAnaHApW5D8Q2qMUbhDy6F2n2QHGxibPDWXpv0wHM/tMI7su1hx79YUjGSp4mFiOCzQD oS+qP/HzoNW+aIaxNytrIu8sDxRfzrnhXLwlqBZj8b0uKe/g5PsipRUPfI+B5iAUmOTA 4TOh98OFSPp2UPMYOx6w/YsgJgoX/h/AuXUgt3/Yg2/JlhswuqaAy1Lw4PLg8kRqhrkz 76cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790753268; x=1791358068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WruczPkazS4ZUlcOrN4t2XFu86i7R3FFqgwfWNzE8vs=; b=pJ1fUpIdWDvaUKFO/06WPumaS0JpRpY7WHflv8QwH5EpyRbWnzKzaCfkESdg9LmUs/ NMZE8C1XJgDw3UeR9lstK5FcdzgSlT6SBoemqFarCF0dxDjqb+kG8vJhqrXnRDbihr6l v3zKwCIdpeaU5SKxV6k3W+STARPHmQiZn+73AMJOHhZmle1u9Bzm7LbhziBSudaXWhgX o2u6nyfewcfTwD8RpIbMmpbqLPkCm7wmbtMq1xOzmshKS4E1vaUdU1J43UHmhJi2Vkab uEbKrWSNxOZbisiLM4/6faNhEL04y/7N5gxRh9o2yN3xm8zWn093USUjvR4o6tmEYRyb lrbw== X-Gm-Message-State: AFuF++nPUjGqeipuAM+JghVXS7eRIeSa/+1BmWNxAyqtPhpkSYjK/tgv BCqpYItx2QdpRerddR+LbHrzBUkFDJm4obQ8eYpnpe7tYdzb4QEegc5b X-Gm-Gg: AYBFou0Hsn09NBfPGRR5CR5blDVpmP0BgA3OWW6Qo4aJnPBcURW/jx+wrwr2arONWdK GkdXYHZvhLg+tgm8oorWQ+yXFC+OEbaSAipKh9Z1Cz4UgE0AfLG6RozjcLFSNN4oe1EuELw749/ ZeuMvjbdqJncV92I3e2VmGJ1hytMHeiBt0KdwNaBcdcyIt9D0A9UcwfQGl1K3rnulpdtGI2Giru WNJykLjtIxNm58SnZ7jNT5OPJdly86FsNW8CaL6PagFWJE+lrXJcSb93cFPRzj6xXpemzaLjtsN 88kXu8lH7yGN5eXu28bgnBPQ7v3HFKn9fCk3e5pS4/40cVkkNMoLjMQaavidPlIIu19YwmIUMSU SoxJ2PwvkBlfjo0ZsqbSkCs2d5LNGbqQqueUaMmY9Md3dm0l482Cj2Zaj6XbI8iNgashK+9gZcJ NO4Xbz7+UzZSlWhoitD8ozZB2rvLkr6zZQYSsGu6TQ/3ePiVuDXMf9gmp615izQ6L5L2kp1CQQc rEt2jz7zalVzj6Uc98= X-Received: by 2002:a05:600c:3b1a:b0:49f:fe90:de63 with SMTP id 5b1f17b1804b1-4a01b12cbb8mr6207775e9.28.1790753267817; Wed, 30 Sep 2026 00:27:47 -0700 (PDT) Received: from xeon ([188.163.112.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a015a84419sm27680985e9.1.2026.09.30.00.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 00:27:47 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Pavel Machek , Svyatoslav Ryhel Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, mfd@lists.linux.dev Subject: [PATCH v1 1/1] leds: Add driver for MAX8907 LED cell Date: Wed, 30 Sep 2026 10:27:32 +0300 Message-ID: <20260930072732.66578-2-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260930072732.66578-1-clamor95@gmail.com> References: <20260930072732.66578-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a small driver to control the LED cell provided by the MAX8907 PMIC. The LED does not require any specific configuration and is folded into the PMIC's node. Signed-off-by: Svyatoslav Ryhel --- drivers/leds/Kconfig | 7 ++++ drivers/leds/Makefile | 1 + drivers/leds/leds-max8907.c | 81 +++++++++++++++++++++++++++++++++++++ drivers/mfd/max8907.c | 1 + include/linux/mfd/max8907.h | 2 +- 5 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 drivers/leds/leds-max8907.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 59445bbf2140a..ff00ecf5d858d 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -813,6 +813,13 @@ config LEDS_MAX77705 help LED driver for MAX77705 PMIC from Maxim Integrated. +config LEDS_MAX8907 + tristate "LED support for MAX8907 PMIC" + depends on LEDS_CLASS && MFD_MAX8907 + help + This option enables support for on-chip LED drivers on + MAXIM MAX8907 PMIC. + config LEDS_MAX8997 tristate "LED support for MAX8997 PMIC" depends on LEDS_CLASS && MFD_MAX8997 diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index ed3fbf2aa2d2d..b9e815b2416d2 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -66,6 +66,7 @@ obj-$(CONFIG_LEDS_LTC3220) += leds-ltc3220.o obj-$(CONFIG_LEDS_MAX5970) += leds-max5970.o obj-$(CONFIG_LEDS_MAX77650) += leds-max77650.o obj-$(CONFIG_LEDS_MAX77705) += leds-max77705.o +obj-$(CONFIG_LEDS_MAX8907) += leds-max8907.o obj-$(CONFIG_LEDS_MAX8997) += leds-max8997.o obj-$(CONFIG_LEDS_MC13783) += leds-mc13783.o obj-$(CONFIG_LEDS_MENF21BMC) += leds-menf21bmc.o diff --git a/drivers/leds/leds-max8907.c b/drivers/leds/leds-max8907.c new file mode 100644 index 0000000000000..358505a1c799f --- /dev/null +++ b/drivers/leds/leds-max8907.c @@ -0,0 +1,81 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include +#include +#include +#include + +struct max8907_led_data { + struct max8907 *max8907; + struct regmap *regmap; + struct led_classdev cdev; +}; + +static enum led_brightness max8907_led_get_brightness(struct led_classdev *cdev) +{ + struct max8907_led_data *ddata = container_of(cdev, struct max8907_led_data, cdev); + unsigned int brightness_lvl; + int ret; + + ret = regmap_read(ddata->regmap, MAX8907_REG_WLED_CNTL, &brightness_lvl); + if (ret) + return LED_OFF; + + return brightness_lvl; +} + +static int max8907_led_set_brightness(struct led_classdev *cdev, + enum led_brightness brightness) +{ + struct max8907_led_data *ddata = container_of(cdev, struct max8907_led_data, cdev); + int brightness_lvl, ret; + + brightness_lvl = clamp(brightness, LED_OFF, LED_FULL); + + if (brightness_lvl) { + ret = regmap_write(ddata->regmap, MAX8907_REG_WLED_CNTL, brightness_lvl); + if (ret) + return ret; + } + + return regmap_update_bits(ddata->regmap, MAX8907_REG_WLED_MODE_CNTL, + LED_ON, brightness_lvl ? LED_ON : LED_OFF); +} + +static int max8907_led_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct max8907 *max8907 = dev_get_drvdata(dev->parent); + struct max8907_led_data *ddata; + + ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + ddata->max8907 = max8907; + ddata->regmap = max8907->regmap_gen; + + platform_set_drvdata(pdev, ddata); + + ddata->cdev.brightness = LED_OFF; + ddata->cdev.flags = LED_CORE_SUSPENDRESUME; + ddata->cdev.max_brightness = LED_FULL; + ddata->cdev.name = dev_name(dev); + + ddata->cdev.brightness_get = max8907_led_get_brightness; + ddata->cdev.brightness_set_blocking = max8907_led_set_brightness; + + return devm_led_classdev_register(dev->parent, &ddata->cdev); +} + +static struct platform_driver max8907_led_driver = { + .driver.name = "max8907-leds", + .probe = max8907_led_probe, +}; +module_platform_driver(max8907_led_driver); + +MODULE_AUTHOR("Svyatolsav Ryhel "); +MODULE_DESCRIPTION("MAX8907 LED driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c index a8cb2071aa7f4..b4562ec0ce18f 100644 --- a/drivers/mfd/max8907.c +++ b/drivers/mfd/max8907.c @@ -21,6 +21,7 @@ static const struct mfd_cell max8907_cells[] = { { .name = "max8907-adc", }, + { .name = "max8907-leds", }, { .name = "max8907-regulator", }, { .name = "max8907-rtc", }, }; diff --git a/include/linux/mfd/max8907.h b/include/linux/mfd/max8907.h index d960dfdd808ba..15901a1b07424 100644 --- a/include/linux/mfd/max8907.h +++ b/include/linux/mfd/max8907.h @@ -112,7 +112,7 @@ #define MAX8907_REG_CHG_IRQ2_MASK 0x81 #define MAX8907_REG_CHG_STAT 0x82 #define MAX8907_REG_WLED_MODE_CNTL 0x84 -#define MAX8907_REG_ILED_CNTL 0x84 +#define MAX8907_REG_WLED_CNTL 0x85 #define MAX8907_REG_II1RR 0x8E #define MAX8907_REG_II2RR 0x8F #define MAX8907_REG_LDOCTL20 0x9C -- 2.53.0