From: Yichong Chen <chenyichong@uniontech.com>
To: tytso@mit.edu, linux-ext4@vger.kernel.org
Cc: adilger.kernel@dilger.ca, libaokun@linux.alibaba.com,
jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com,
yi.zhang@huawei.com, linux-kernel@vger.kernel.org,
Yichong Chen <chenyichong@uniontech.com>
Subject: [PATCH] ext4: drop tmp inode ownership before migration cleanup
Date: Wed, 30 Sep 2026 16:02:41 +0800 [thread overview]
Message-ID: <20260930080241.414973-1-chenyichong@uniontech.com> (raw)
After the extent tree is transferred to the original inode,
ext4_journal_ensure_credits() can fail before tmp_inode is cleared. The
subsequent iput(tmp_inode) may then free the transferred tree.
Clear tmp_inode's size and block count as soon as ownership is transferred.
Fixes: a413036791d0 ("ext4: Provide function to handle transaction restarts")
Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
---
fs/ext4/migrate.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index e588b4157604..11b3da396966 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -570,6 +570,12 @@ int ext4_ext_migrate(struct inode *inode)
free_ext_block(handle, tmp_inode);
}
+ if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
+ i_size_write(tmp_inode, 0);
+ tmp_inode->i_blocks = 0;
+ EXT4_I(tmp_inode)->i_csum_seed = tmp_csum_seed;
+ }
+
/* We mark the tmp_inode dirty via ext4_ext_tree_init. */
err = ext4_journal_ensure_credits(handle, 1, 0);
if (err < 0) {
--
2.51.0
reply other threads:[~2026-09-30 8:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930080241.414973-1-chenyichong@uniontech.com \
--to=chenyichong@uniontech.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®