From: Rupesh Majhi <zoone.rupert@gmail.com>
To: andriy.shevchenko@intel.com
Cc: "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/3] iio: pressure: dps310: read buffered samples from the hardware FIFO
Date: Wed, 30 Sep 2026 11:29:52 +0300 [thread overview]
Message-ID: <20260930082952.878967-1-zoone.rupert@gmail.com> (raw)
In-Reply-To: <arriSm8L567yqOjV@ashevche-desk.local>
On Tue, Sep 29, 2026 at 12:55:22AM +0300, Andy Shevchenko wrote:
> On Tue, Sep 29, 2026 at 12:11:25AM +0300, Rupesh Majhi wrote:
> > +/* Returns which measurement the entry came from, or a negative error */
> > +static int dps310_fifo_read_entry(struct dps310_data *data, s32 *value)
> > + __must_hold(&data->lock)
>
> Hmm... Don't you want to also add lockdep annotations?
All __must_hold() functions here are static and called only from
dps310.c, which is opted into context analysis since patch 10 of v8, so
clang checks every caller. If you still want lockdep_assert_held() I
would add it to all 20 in a separate patch, as 12 are already applied.
Rupesh
next prev parent reply other threads:[~2026-09-30 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 21:11 [PATCH v9 0/3] iio: pressure: dps310: hardware FIFO support Rupesh Majhi
2026-09-28 21:11 ` [PATCH v9 1/3] iio: pressure: dps310: read buffered samples from the hardware FIFO Rupesh Majhi
2026-09-28 21:55 ` Andy Shevchenko
2026-09-30 8:29 ` Rupesh Majhi [this message]
2026-09-30 9:02 ` Andy Shevchenko
2026-09-28 21:11 ` [PATCH v9 2/3] iio: pressure: dps310: derive the drain interval from the watermark Rupesh Majhi
2026-09-28 21:11 ` [PATCH v9 3/3] iio: pressure: dps310: implement .hwfifo_flush_to_buffer() Rupesh Majhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930082952.878967-1-zoone.rupert@gmail.com \
--to=zoone.rupert@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®