mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Natasha Klaus <natalie.klaus@runtimeverification.com>
To: laurent.pinchart@ideasonboard.com
Cc: david.laight.linux@gmail.com, hansg@kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	mchehab@kernel.org, natalie.klaus@runtimeverification.com,
	noambs2999@gmail.com, ribalda@chromium.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 1/3] media: uvcvideo: Let uvc_parse_frame() report a skipped frame
Date: Wed, 30 Sep 2026 13:33:41 +0300	[thread overview]
Message-ID: <20260930103341.256220-1-natalie.klaus@runtimeverification.com> (raw)
In-Reply-To: <20260928205037.GL4406@killaraus.ideasonboard.com>

On Mon, Sep 28, 2026, Laurent Pinchart wrote:
> On what device have you seen this occurring ? How did you test this
> patch ?

On no device. Noam found the overflow by reading the code. The zero
size case came from my review of his patch, done with an LLM tool
(see my reply on 2/3). There is no user report behind either.

1/3 is the refactor Ricardo suggested on the list, so that 2/3 and
3/3 can drop one bad frame instead of the whole streaming interface.
Apart from the truncated descriptor message moving to dev_warn(), it
changes no behaviour on its own.

Testing: Noam ran the series on a UVC gadget over dummy_hcd. One
format had an over-U32_MAX frame, a zero-size frame and a valid
frame. Both bad frames were skipped and the valid one was exposed.
I built it on x86_64.

Not tested: any physical camera, the -ENODATA truncated descriptor
path, 32-bit builds.

Natasha

  reply	other threads:[~2026-09-30 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 11:15 [PATCH v3 0/3] media: uvcvideo: harden the frame buffer size computation Natasha Klaus
2026-08-20 11:15 ` [PATCH v3 1/3] media: uvcvideo: Let uvc_parse_frame() report a skipped frame Natasha Klaus
2026-09-28 20:50   ` Laurent Pinchart
2026-09-30 10:33     ` Natasha Klaus [this message]
2026-08-20 11:15 ` [PATCH v3 2/3] media: uvcvideo: Fix integer overflow in frame buffer size calculation Natasha Klaus
2026-09-28 20:53   ` Laurent Pinchart
2026-09-30  8:58     ` Natasha Klaus
2026-08-20 11:15 ` [PATCH v3 3/3] media: uvcvideo: Skip frame descriptors with a zero computed size Natasha Klaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930103341.256220-1-natalie.klaus@runtimeverification.com \
    --to=natalie.klaus@runtimeverification.com \
    --cc=david.laight.linux@gmail.com \
    --cc=hansg@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=noambs2999@gmail.com \
    --cc=ribalda@chromium.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®