mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuba Piecuch <jpiecuch@google.com>
To: Andrea Righi <arighi@nvidia.com>
Cc: Kuba Piecuch <jpiecuch@google.com>, Tejun Heo <tj@kernel.org>,
	 David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	 Emil Tsalapatis <emil@etsalapatis.com>,
	sched-ext@lists.linux.dev,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] selftests/sched_ext: Add a test for ops.dequeue() on remote local DSQ moves
Date: Wed, 30 Sep 2026 14:27:04 +0000	[thread overview]
Message-ID: <20260930142706.560608-1-jpiecuch@google.com> (raw)
In-Reply-To: <ar0Ua_zkwY7P22iI@gpd4>

Hi Andrea,

On Wed, Sep 30, 2026 at 03:53:47PM +0200, Andrea Righi wrote:
> If there are MAX_DISPATCH_POPS or more stale entries in front of a valid one, we
> return without dispatching anything and the CPU goes idle. It's quite unlikely,
> but maybe we could re-kick this CPU when the loop runs out of pops while the
> queue is still non-empty to make the test a bit more robust?

Good idea. v3 uses bpf_map_peek_elem() to check the queue and kicks the CPU
if the queue is not empty.

> Nit: maybe reset enqueue_seq as well?

Done.

> Nit: uei isn't reset between scenarios, so in theory this check in the
> second scenario could pass using the exit record of the first one. So maybe we
> should add:
> 
>     memset(&skel->data->uei, 0, sizeof(skel->data->uei));

Good catch, done.

> Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks for the review! I've added your tag in v3.

Thanks,
Kuba

      reply	other threads:[~2026-09-30 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 11:47 [PATCHSET v2 sched_ext/for-7.3-fixes] sched_ext: Fix missing " Kuba Piecuch
2026-09-30 11:47 ` [PATCH v2 1/2] sched_ext: Call ops.dequeue() when a task arrives on a remote local DSQ Kuba Piecuch
2026-09-30 11:47 ` [PATCH v2 2/2] selftests/sched_ext: Add a test for ops.dequeue() on remote local DSQ moves Kuba Piecuch
2026-09-30 13:53   ` Andrea Righi
2026-09-30 14:27     ` Kuba Piecuch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930142706.560608-1-jpiecuch@google.com \
    --to=jpiecuch@google.com \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=emil@etsalapatis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®