From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468D95187CA for ; Wed, 30 Sep 2026 18:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790793589; cv=none; b=YQ0XwM8cy0NSM7TvWNN/Rwo3R/+rkPhXfeKZ+Yl3b7RV7DClwPZrmhHfaevNX4QbK8VPt57758NmBLjQ6Y8Q7BSrS6PIdoZHeeLkQnpPSRlJ8Wj3A57vCcO1gqzBPp7jS/1U7AYYqEY9gq47A8ovfHQaTmPFAd+u0H9NRXLNM0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790793589; c=relaxed/simple; bh=WmojZX7NIQZ4bKwgYfjEYA6u/H5MCNneuKe2H/Wr+nM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S2txnmscmELC/5ccsOLSSFMNYY6y0ZxJJrhgkSgWxlse+B/VHrnwDlACJEaPnXsFxhSemZ6LNkPcJuSnCJD1Z3oMpTO5Q49aTWi9Z3v4lJfELzmDgvRgg0/cXoBc1Y/zIHzZOjzgtD475GhEgR/S1LXwpLMfz3uw5CIGLYv6bho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N0CgT2E9; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N0CgT2E9" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5b8b3c8c4bbso52143e87.0 for ; Wed, 30 Sep 2026 11:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790793585; x=1791398385; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UJ5fYEtVagCgzeX5DZQ2/ZY0rZBUHHKaKAAihUWn64U=; b=N0CgT2E9i1klCmAMSzFBYy833ow9kI+YFYIAehyLibvZMPrrM2wFBsUGMhCKfD6yk1 QX9Ev1tuIO294fNd3KGmWcr2KA/BqCy0Sq1X6mTialxn6me4KJbRMktgSfGmi02BpwtS F2L+m+6mWtQCsKrgcaC60vwn+Q6p4FF5S4l9hAio3dMN992iZfPLczkM20QJABIzWBED p4mGmDaS0OeLW8gh3/QGSaKRxIo8pdEr9dNIDJ/kU+/Nz2jBGc0rloSKZ3D37JwCbuZ2 PShULLlxmMtyYvcm69mSapcnS+2cCXY6dbU05Dakq/dkh7azBV2tFrLCJcdYasf5RMCI Julw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790793585; x=1791398385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UJ5fYEtVagCgzeX5DZQ2/ZY0rZBUHHKaKAAihUWn64U=; b=VabRVQWvfBJzy8CqmGBQkLAr9tIw2Axoh1ZRUtwU1fIe397eF0QFVBbKfU+yNsefri ma1FYBdHYBeM5iy7cbetTDr2PwakdzKjHBpGmOXbvvllk9sca94+aWbR1G6HqF2xb/JG 5EDdLvbG6k9gBCpcavF9BEQmtxdlprOUhB10eKulQNEj46v/8YyRr+zHAhsv5OSmKnkD WWcrrkqED8cj6aL5vYUrYs7DJHgUGoIl6ZvOq1yeVbq/R43cUYesJYyjuQABBDttSiua E/s3Y5SVlX3baVY2iE304dCUNLrhviHG0x/5gaQwwkclHfiKQOVoYcGBEibB8pTCJjf5 3Ciw== X-Forwarded-Encrypted: i=1; AKwUvBzrya/w/VjrPSIWbFLF+LhGK/keg1DaZinZE5hrJcygbZbNzwNpkwSfcc5OpIdq8MuLpZRok2DSz6WtTvY=@vger.kernel.org X-Gm-Message-State: AFq9FYI+l4Ihda7ZElTjASh9ktc0ugKFIi7WrHN0ZZkuPtCJH/5whOh8 hfbdU3EUuFxNVCWK3x8deMUH2PHVVi9Q7pZxaxRlK7mExRdpe7XrZM7h X-Gm-Gg: AYBFou1krtGjnN+UbCkBGUCRDOHfL3E6oPoWdVt+POhCIPVZf3f+Mdr8UuHHk2oHNIS 2M5oNlEUJBi7d/eQvvORKF9eDQmVL0Igcns1ncKmYMSSfgcuQwrF3pvmrU9Tq+7DmnrtRIjO6Iw WPseFbgqIc6CoCcOwY8AP/st/k0jdJ6S7+KoSUW/JSjqUt4GJ07cwgXhWaMUysyQSv5b1ELFq7n 9LdRcWG84hXvW7QIhPudwx/ySVWjuQ6fp+XPMiPl09XmFQJWTEiDJuBXY6q0fYkCAMm0xK5QUNb mZOyxOKFMhK+PaPuP7XnBZNjwKTpf4XRajnQCpnz7m+WetZVZqzQ9hsTUcPOKQbDa8n04W89/JS 4pEmT3Er70TwvpnzW/AuxjnpdJpXeHOw5KomReR9KA35TwHuHyFSh2rNRMS7tWbxVhuy1xoKYjF ul7SWRMcFH7yFdOvfOgkOYaHY2Zo0lyxfch6YKEgFJByrSE1uzbxbN+9I+0MwLTSuRcFyZY63Hz AmQtJr6dD55m0L6lbgMnzfq3pEstthwMa63mXTAjBBo X-Received: by 2002:a05:6512:1287:b0:5b8:c311:88e8 with SMTP id 2adb3069b0e04-5ba433ef5e1mr158262e87.26.1790793585152; Wed, 30 Sep 2026 11:39:45 -0700 (PDT) Received: from dau-home-pc.. ([212.35.169.181]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ba42fbb999sm156593e87.62.2026.09.30.11.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 11:39:44 -0700 (PDT) From: Anton Danilov To: netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Ido Schimmel , Andrew Lunn , linux-kernel@vger.kernel.org Subject: [PATCH net-next v5 14/14] vxlan: report a circular route as SKB_DROP_REASON_RECURSION_LIMIT Date: Wed, 30 Sep 2026 21:39:10 +0300 Message-ID: <20260930183910.3151873-15-littlesmilingcloud@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260930183910.3151873-1-littlesmilingcloud@gmail.com> References: <20260930183910.3151873-1-littlesmilingcloud@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit udp_tunnel_dst_lookup() and udp_tunnel6_dst_lookup() return -ELOOP when the route to the remote end goes out of the vxlan device itself, and vxlan_xmit_one() counts that in collisions, apart from the -ENETUNREACH of a failed lookup. The drop reason does not tell them apart: both are reported as SKB_DROP_REASON_IP_OUTNOROUTES, which describes a failed route lookup. ip_tunnel and ip6_tunnel make the same check, rt->dst.dev == dev in ip_tunnel_xmit() and ip_md_tunnel_xmit() and tdev == dev in ip6_tnl_xmit(), and report it as SKB_DROP_REASON_RECURSION_LIMIT since earlier in this series. Report the vxlan case the same way, so that vxlan and these tunnels name this misconfiguration with one reason. Assisted-by: LLM Signed-off-by: Anton Danilov --- drivers/net/vxlan/vxlan_core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index 0d98e29e2d72..7c94a630d184 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -2547,7 +2547,10 @@ void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, tos, use_cache ? dst_cache : NULL); if (IS_ERR(rt)) { err = PTR_ERR(rt); - reason = SKB_DROP_REASON_IP_OUTNOROUTES; + if (err == -ELOOP) + reason = SKB_DROP_REASON_RECURSION_LIMIT; + else + reason = SKB_DROP_REASON_IP_OUTNOROUTES; goto tx_error; } @@ -2633,7 +2636,10 @@ void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, if (IS_ERR(ndst)) { err = PTR_ERR(ndst); ndst = NULL; - reason = SKB_DROP_REASON_IP_OUTNOROUTES; + if (err == -ELOOP) + reason = SKB_DROP_REASON_RECURSION_LIMIT; + else + reason = SKB_DROP_REASON_IP_OUTNOROUTES; goto tx_error; } -- 2.47.3