Re: [PATCH net-next] dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema

[Rob Herring <robh@kernel.org>]

On Tue, Sep 29, 2026 at 10:27:17PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 5 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 2 · Low: 3
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] The schema leaves out properties the driver needs and drops
>   value constraints the hardware relies on: (1) 'buf-size' and 'desc-…
> - [Medium] The 'reg' description in the new schema (lines 21-33) gives a
>   fixed four-entry positional layout: [0] external interface control…
> - [Low] The patch deletes
>   Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt without…

Fixed in another patch.

> - [Low] In the new binding, the port 'media-type' enum (lines 115-119)
>   allows only 'copper' and 'fiber'.
> - [Low] The schema example (lines 135-142) sits at the top level with no
>   parent bus node that sets '#address-cells = <2>; #size-cells = <2>;'.

Fixing the rest of these.

pw-bot: cr