From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f40.google.com (mail-pj2-f40.google.com [74.125.227.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7654052CCF9 for ; Wed, 30 Sep 2026 21:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.168 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790804633; cv=none; b=GVdsfDv5M8NR0wg+FLd235roGM9YiE+2EHWJQRO5uSaxO9RlcgH+gl0rd3Vbu4Ghsl3hmyHYZD/2ByfJ1xNK6a7EUdlqgoztZuLxN2mmT0jOEbriZk/98HIG6MJB048/Rc06tLDXTyseM9E8/QJEtRxBSqL6PRb24ZDkkkyhtXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790804633; c=relaxed/simple; bh=JaYYc/MebRQQvnPhb6g6B2V4uIViyu5GZFRD0yqRn88=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hsy6jOeipWF2j0nLmGRgZIo+GObOTAGLAEx9eg41sOiqX4r8FL96mHPZR0giXn4jgQI5PQOSG3sZleR7Efz3QaU4ooHlM8XpKaD3ebMJJdLnhJiAGHIGhJ63tOaoH/jcXGfTaf1OIOKyydpXGdKV+WtMTFjTvpNuZjPgRVMPHrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ML7CogMM; arc=none smtp.client-ip=74.125.227.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ML7CogMM" Received: by mail-pj2-f40.google.com with SMTP id 98e67ed59e1d1-3a0d31bda43so3696861a91.1 for ; Wed, 30 Sep 2026 14:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790804631; x=1791409431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xxKjjaswIqYpJP4gFTjG5f76wpVmS82nrOI8R56lUWA=; b=ML7CogMMjmT59CJD754AnaJew8PhGXWjUhMLfnqdonV9SAF+E33RYV8DBCzO0iX37a +p6A/hEhwrDhOOeKQ2vAkxh4XboWnK9QtF8/dZSq0DyP3r92QrJxcAWCU/v+4ldqtvmP +vbgVzLLmRaVIZ4qaPYhymYJBXsAMFir5Vn1gQXoUxZE2mFJfAMjfny8pcIGuZSH4Yby pOEtDE4jYR+jRvUa9GBucpDoKTYAFOGai2khUYMSl2W8REXWz1Sh44srBX51OJE+jdnI aOX5TUXZKw/t8ZUSDM8mCHio22vMwHO1MxdiR2jCEkn70lrsp5dJ+IVzOtfxqijLiilX i6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790804631; x=1791409431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xxKjjaswIqYpJP4gFTjG5f76wpVmS82nrOI8R56lUWA=; b=yZJzOBQhOOzfXVgTq+SwCFNas8sHDq54VSfav0ASVrd5PZn8p0X02Fl8Bpk9rAA4uZ SAaIkFPFioXhfQ39ODtLj45U+z0N+8l/D35xPZcML796QK1VyOtv1zfhrdAOjV+qpM1O nRXSnGGZe+r9ak2bqAzUX876v1rw9v0nTR3Y34CKq/7zS+dFYfY9dKrjTd90+tsySGJh 334J5ctJBGVE/JuCfQk6TplJFHOtSHqhp+VlEKcGFBAbnw8y3iOFzp+rFr4vE+2pxp2f bjVThdICGHt3gTjQoxI3U6PFj0860gZfA+mPEzuxBYROf3degJVeWDOoUrD2xsPInKKY P01w== X-Gm-Message-State: AFq9FYL5IcWe+XvycL1cMHDTJTVUYwxx7M6GCrCdzsvfpbFA+BdOIOa5 rQyKV/XXkqc4iTraS8clEVjfeFwAebQ+uuXrB1bWyAAFEiPT4Y05NXfIUk2SGBH7 X-Gm-Gg: AYBFou3CZ6R15p6p/6e4g2WxCXc1cXK4liu7EvE10S7YQXXkiofeV5ypM+VjRCV14sg OqAJaSWMe7CmjV/RiRVWodsAfEvF4m3HtSK4qJVUnkfc1ZkpDbCbic+NpkuwLiTAOCKMPYpzLpp wQ/oQgQL10JYiutf+afHnrAKWGSuYsdqEE0ba+eim5V3WLGqpFI+jYzOmqa1qcaORI07bzC3yCS qTpg9xfSjJH3o83aiWbltxVW2EezChoTuHy88+vnn0gfMjrMTwzB7nC1Y5WGMyrxNLPwmHG4c3p j9Ozz14kBrD0bnytRsEjFtjUB9VCaYfOS5GWV4Yshh4Qwo038A3io4973IwrrOUWQg1Lc5u7qNe u3JumCRYoEDd0V5erbvHA/ixNNFbOLTdfTGNF7w1iTimL/ct7HErGFzfY7JOFph+DB9DZFJSR87 SdOtTqCAzDk9n4E7jQ1VIpAgsKNFRJs0+XPrDHmtJwTkAqIMtnZqtmY8KVCr3LxT0KGg4= X-Received: by 2002:a17:90b:35cf:b0:3a0:4384:adf6 with SMTP id 98e67ed59e1d1-3a4d05a6f4fmr1835573a91.0.1790804630754; Wed, 30 Sep 2026 14:43:50 -0700 (PDT) Received: from TC-LAPTOP.lan ([99.30.92.7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4f47cbd1dsm1060539a91.16.2026.09.30.14.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 14:43:50 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, dan.scally@ideasonboard.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, andriy.shevchenko@intel.com, v.vitovt@gmail.com, dmanresa@gmail.com, Thierry Chatard Subject: [PATCH v11 6/9] platform/x86: int3472: tps68470: use a common always-on VIO regulator init_data Date: Wed, 30 Sep 2026 14:43:18 -0700 Message-ID: <20260930214321.600863-7-tchatard@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260930214321.600863-1-tchatard@gmail.com> References: <20260930214321.600863-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The surface_go and intel_nvl board data define byte-identical VIO regulator init_data (1.8006 V, apply_uV, always_on). Replace both with a single shared common_tps68470_vio_reg_init_data so new boards with the same requirement can reuse it instead of duplicating the definition. No functional change. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Thierry Chatard --- .../x86/intel/int3472/tps68470_board_data.c | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c index c53542465..c2ec802fc 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -75,8 +75,12 @@ static const struct regulator_init_data surface_go_tps68470_vcm_reg_init_data = .consumer_supplies = int347a_vcm_consumer_supplies, }; -/* Ensure the always-on VIO regulator has the same voltage as VSIO */ -static const struct regulator_init_data surface_go_tps68470_vio_reg_init_data = { +/* + * Common always-on VIO regulator init_data. Its voltage must match VSIO; + * boards using the TPS68470 I2C pass-through that need this exact setting + * can share this instead of defining their own. + */ +static const struct regulator_init_data common_tps68470_vio_reg_init_data = { .constraints = { .min_uV = 1800600, .max_uV = 1800600, @@ -123,7 +127,7 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = [TPS68470_CORE] = &surface_go_tps68470_core_reg_init_data, [TPS68470_ANA] = &surface_go_tps68470_ana_reg_init_data, [TPS68470_VCM] = &surface_go_tps68470_vcm_reg_init_data, - [TPS68470_VIO] = &surface_go_tps68470_vio_reg_init_data, + [TPS68470_VIO] = &common_tps68470_vio_reg_init_data, [TPS68470_VSIO] = &surface_go_tps68470_vsio_reg_init_data, [TPS68470_AUX1] = &surface_go_tps68470_aux1_reg_init_data, [TPS68470_AUX2] = &surface_go_tps68470_aux2_reg_init_data, @@ -339,15 +343,6 @@ static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_data = { .consumer_supplies = ovti13b1_vcm_consumer_supplies, }; -/* Ensure the always-on VIO regulator has the same voltage as VSIO */ -static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_data = { - .constraints = { - .min_uV = 1800600, - .max_uV = 1800600, - .apply_uV = true, - .always_on = true, - }, -}; static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_data = { .constraints = { .min_uV = 1800600, @@ -364,7 +359,7 @@ static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pdata = [TPS68470_CORE] = &intel_nvl_tps68470_core_reg_init_data, [TPS68470_ANA] = &intel_nvl_tps68470_ana_reg_init_data, [TPS68470_VCM] = &intel_nvl_tps68470_vcm_reg_init_data, - [TPS68470_VIO] = &intel_nvl_tps68470_vio_reg_init_data, + [TPS68470_VIO] = &common_tps68470_vio_reg_init_data, [TPS68470_VSIO] = &intel_nvl_tps68470_vsio_reg_init_data, }, }; -- 2.53.0