From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f38.google.com (mail-pz2-f38.google.com [74.125.228.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16A033D6FA for ; Thu, 1 Oct 2026 00:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.38 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790814192; cv=none; b=YX10jC8XAjbSwk/2v0N9e356HQOANC70kL1HlQaBkS7IeKXslCHjHdkHb5rZUMMz0mKfzrnayzqqgLo6rtxjYRtwhAg5BzSkwinJLLn89nc+XGfHpVPkyMzctg+0K4xpb2Z8LYrJB5NCLFqUgOAxrIrxUOPKvi5JkmAzFPLgHzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790814192; c=relaxed/simple; bh=XZLJ92YYGgo2EnDF0zop9dxOWN/HVAtYL4WCxjC3QM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lu8JBQHDMl6bYy3oBMTvhTA5i5ThIhEcaf6Q2QgTg7vPq049G7EYmQ488hsnBRpY+vWYUR9+mlvqyeQ8Tr93XUy8HVeAdi+OFQ9nvjZlMJ9LZ3YZGQ6agbDS+/k31ix1YuI0cCisMj95o/seWIItiTdTjp9VrCgKr+aElXoQ4U0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iqmeRwyq; arc=none smtp.client-ip=74.125.228.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iqmeRwyq" Received: by mail-pz2-f38.google.com with SMTP id d2e1a72fcca58-883a16b758dso848651b3a.1 for ; Wed, 30 Sep 2026 17:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790814190; x=1791418990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6owLhFrZhOrof0QRHeePhFj2MbtqvsfbNFfaY8xy+tA=; b=iqmeRwyqfia5JPiIRCFEuoTJrbA3NybnFjd88vwaCMDcwEhsDh7v8xQeQ9ndjGd/6t MysLBbo2BMQNjldlCILrVRcR0MbeNcbGT3ZDPUchAkxQatz4HejbH7gB4plZD6z2K7G5 WXEqsVwewp4r91FMXQN5OcUdKKW4Isa8oiPzczHoHUodzQAaC6FTUL/y+bb/wf0ASxGh THSUqSjj7rvk54kE/gIkXsiJmmsv5kYirPAfUxoCaPDGO3Re+J303QPn8P+mtsSyF8q+ ZN2kmtKRl55GeQu3hit4XJX0o6ntddGYXjlASH1XzPclo4W8H8JAvhaQxEyH+Eh9HHuI iliA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790814190; x=1791418990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6owLhFrZhOrof0QRHeePhFj2MbtqvsfbNFfaY8xy+tA=; b=a7yUnjZdzhjtTYBBmdwQ6ClSo9TV2MSh1Bu7JidWLqc4o3LObWbZ8+pFN4nJnDh0jr AWVrhMx4ps6H6uepzgHKA1NZTvJCXWdqkwKg0wiZ90h/f1z+bLT4hBaaUIZABgjA0EQX vwjqn+Nm9K1ca8Vq8u5eiKXV+mm6iRJAtqkfa4gA9WYL3HLkAeEfLKbTgQXPTzGjWNTP ub28myKjCdXj20U8C11mmQT0AHar/ieNHdeSXLgOKbMUVnM4JCNswfLturHyuNsDU5xo gu0qh5x83O/f4MIdFnF6R2zVNpqVL7Lf+yryKbwDOWuwKOJ2xab2NssqNDwI34lzGTvi kVNg== X-Forwarded-Encrypted: i=1; AKwUvBxtXDENVK3gIhSh9sxQfhoM2vJVOzl+D77zahc47oLym4udPLwMx1zS24zjT4FMvVz+jYS3xP1xVFTcMtQ=@vger.kernel.org X-Gm-Message-State: AFuF++lOYbDlf3pfuNiigSsDWLoqmyTziOvmEJhljweJKqfUSpx652W/ HSe6X6GDzVnwOPzpshGuZT1I/EMscnJJU5rD2vv5t0GTsQX/MyjXYCkL X-Gm-Gg: AYBFou0qHQZktx6t0Qckfn7aj2am29+wsHe2cPrjm80ISbLIG3hcTSEfxnz4Z109Wdx Zw0aqzn5h9UCD1az8fB5S0Bwwl2pWNHEsAdocXF72PMiAiNUhE80b/udDl9BJ882jRPLpvoHHbp RVAFCMeW8mXgheFCl/TU9PdDrSou3LJLGCVTrFRtPnXNNNZV9+DJVpx1Ny7L02Een+IxdHxnyvq qQAvero+p7giL9tHPxnPif+srybY4N5QHKaGVS+Y5xr9F6jtjLD+9vT57Iimf4jtZBHPeYkldn4 F8g8Q1ogOMCGFecLdt1YGQ6ha5uuMtAaXf950hgZaqUSFxW6oXaodeQNkPeiQITpMjyCdVjUjrH 33kfJRBPZRenJPKHbxDOlxK3YN3d0r7WXQP8I7p2ewf75USCx5wbJpEFTwXDk45c5eVtWoVXA1E Q+VmmDrpCgmPdCymnLfRl5ErC5wNIGvxQhpjH1L3mGPSqGasdyG4gf1w== X-Received: by 2002:a05:6a20:9c12:b0:3dd:a196:ffd1 with SMTP id adf61e73a8af0-3deacb28af2mr729541637.33.1790814190164; Wed, 30 Sep 2026 17:23:10 -0700 (PDT) Received: from qby-nixos-laptop ([2a13:edc0:18:16f::a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-88818deef3esm247601b3a.29.2026.09.30.17.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 17:23:09 -0700 (PDT) From: Mingyou Chen To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede , Ilya Gladyshev Cc: KentoNion , platform-driver-x86@vger.kernel.org, ted eric , Armin Wolf , linux-kernel@vger.kernel.org, Chris Taraszka , Matias Civadda , =?UTF-8?q?=E9=AB=98=20=E4=BF=8A=E6=96=87?= , powerfullz , =?UTF-8?q?=E5=AD=99=20=E8=AA=89=E9=93=AD?= , =?UTF-8?q?Milo=C5=A1=20Vlku?= , Rsplwe , Bozhen Peng , Anton Karasev , Mingyou Chen , Nika Krasnova Subject: [PATCH v7 2/5] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver Date: Thu, 1 Oct 2026 00:22:36 +0000 Message-ID: <20261001002239.31461-3-qby140326@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261001002239.31461-1-qby140326@gmail.com> References: <20261001002239.31461-1-qby140326@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The bitland-mifs-wmi and legacy redmi-wmi drivers both attempt to bind to the same WMI GUID (46C93E13-EE9B-4262-8488-563BCA757FEF). This overlap causes a device registration conflict, preventing one of the drivers from loading properly depending on the module initialization order. Merge the event handling logic from redmi-wmi into bitland-mifs-wmi. By handling both device layouts within a single driver, we eliminate the GUID ownership conflict. Tested-by: Nika Krasnova Tested-by: Ilya Gladyshev Reviewed-by: Ilya Gladyshev Signed-off-by: Mingyou Chen --- drivers/platform/x86/bitland-mifs-wmi.c | 147 ++++++++++++++++-------- 1 file changed, 101 insertions(+), 46 deletions(-) diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c index dd1648b7de77..85683eb116c9 100644 --- a/drivers/platform/x86/bitland-mifs-wmi.c +++ b/drivers/platform/x86/bitland-mifs-wmi.c @@ -35,6 +35,11 @@ #include #include +#define BI_HOTKEY_CODE(id, low, high) \ + (((u32)(high) << 24) | ((u32)(low) << 16) | ((u32)(id) << 8) | WMI_EVENT_TYPE_HOTKEY) + +#define AI_KEY_VALUE_MASK BIT(8) + #define DRV_NAME "bitland-mifs-wmi" #define BITLAND_MIFS_GUID "B60BFB48-3E5B-49E4-A0E9-8CFFE1B3434B" #define BITLAND_EVENT_GUID "46C93E13-EE9B-4262-8488-563BCA757FEF" @@ -80,9 +85,9 @@ enum bitland_mifs_power_profile { }; enum bitland_mifs_event_id { - WMI_EVENT_RESERVED_1 = 1, - WMI_EVENT_RESERVED_2 = 2, - WMI_EVENT_RESERVED_3 = 3, + WMI_EVENT_SWITCHVIDEOMODE = 1, + WMI_EVENT_SELECTIVE_SCREENSHOT = 2, + WMI_EVENT_ALL_APPLICATIONS = 3, WMI_EVENT_AIRPLANE_MODE = 4, WMI_EVENT_KBD_BRIGHTNESS = 5, WMI_EVENT_TOUCHPAD_STATE = 6, @@ -104,6 +109,7 @@ enum bitland_mifs_event_id { WMI_EVENT_FN_5 = 24, WMI_EVENT_REFRESH_RATE = 25, WMI_EVENT_CPU_FAN_SPEED = 26, + WMI_EVENT_CONFIG = 27, WMI_EVENT_GPU_FAN_SPEED = 32, WMI_EVENT_WIN_KEY_LOCK = 33, WMI_EVENT_RESERVED_23 = 34, @@ -607,18 +613,60 @@ static const struct attribute *const laptop_attrs[] = { ATTRIBUTE_GROUPS(laptop); static const struct key_entry bitland_mifs_wmi_keymap[] = { - { KE_KEY, WMI_EVENT_OPEN_APP, { KEY_PROG1 } }, - { KE_KEY, WMI_EVENT_CALCULATOR_START, { KEY_CALC } }, - { KE_KEY, WMI_EVENT_BROWSER_START, { KEY_WWW } }, - { KE_IGNORE, WMI_EVENT_FN_J, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_F, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_0, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_1, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_2, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_3, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_4, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_5, { KEY_RESERVED } }, - { KE_END, 0 } + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_OPEN_APP, 1, 0), { KEY_PROG1 } }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_CALCULATOR_START, 1, 0), { KEY_CALC } }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_BROWSER_START, 1, 0), { KEY_WWW } }, + + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_J, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_F, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_0, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_1, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_2, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_3, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_4, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_5, 0, 0), {} }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_SELECTIVE_SCREENSHOT, 0, 0), + { KEY_SELECTIVE_SCREENSHOT } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_ALL_APPLICATIONS, 0, 0), { KEY_ALL_APPLICATIONS } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_CONFIG, 0, 0), { KEY_CONFIG } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_CONFIG, 1, 0), { KEY_CONFIG } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_SWITCHVIDEOMODE, 1, 0), { KEY_SWITCHVIDEOMODE } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_REFRESH_RATE, 0, 0), { KEY_REFRESH_RATE_TOGGLE } }, + + /* AI button has code for each position */ + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_5, 1, 0), { KEY_ASSISTANT } }, + + { KE_KEY, BI_HOTKEY_CODE(0x19, 1, 0), { KEY_ASSISTANT } }, + + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0x80, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 5, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0x0a, 0), {} }, + + /* Xiaomi G Command Center */ + { KE_KEY, BI_HOTKEY_CODE(0x0a, 1, 0), { KEY_VENDOR } }, + + /* OEM preset power mode */ + { KE_IGNORE, BI_HOTKEY_CODE(0x16, 1, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(0x16, 2, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(0x16, 3, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(0x16, 4, 0), {} }, + + /* Fn Lock state */ + { KEY_FN_ESC, BI_HOTKEY_CODE(WMI_EVENT_FNLOCK_STATE, 0, 0), {} }, + { KEY_FN_ESC, BI_HOTKEY_CODE(WMI_EVENT_FNLOCK_STATE, 1, 0), {} }, + + /* Fn+`/1/2/3/4 */ + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_F, 1, 0), { KEY_F13 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_0, 1, 0), { KEY_F14 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_1, 1, 0), { KEY_F15 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_2, 1, 0), { KEY_F16 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_3, 1, 0), { KEY_F17 } }, + + { KE_END } }; static void bitland_notifier_unregister(void *data) @@ -736,13 +784,36 @@ static int bitland_mifs_wmi_probe(struct wmi_device *wdev, const void *context) &drv_data->notifier); } +static void bitland_mifs_wmi_report_key(struct wmi_device *wdev, u32 payload) +{ + struct bitland_mifs_wmi_data *data = dev_get_drvdata(&wdev->dev); + struct key_entry *entry; + bool autorelease = true; + int value = 1; + + entry = sparse_keymap_entry_from_scancode(data->input_dev, payload); + if (!entry) { + dev_dbg(&wdev->dev, "Unknown WMI hotkey with payload 0x%08x\n", payload); + return; + } + + /* AI key quirk */ + if (entry->keycode == KEY_ASSISTANT) { + value = !(payload & AI_KEY_VALUE_MASK); + autorelease = false; + } + + guard(mutex)(&data->lock); + sparse_keymap_report_entry(data->input_dev, entry, value, autorelease); +} + static void bitland_mifs_wmi_notify(struct wmi_device *wdev, const struct wmi_buffer *buffer) { - struct bitland_mifs_wmi_data *data = dev_get_drvdata(&wdev->dev); const struct bitland_mifs_event *event = buffer->data; struct bitland_fan_notify_data fan_data; u8 brightness; + u32 payload; /* Validate event type */ if (event->event_type != WMI_EVENT_TYPE_HOTKEY) @@ -758,24 +829,13 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev, blocking_notifier_call_chain(&bitland_notifier_list, BITLAND_NOTIFY_KBD_BRIGHTNESS, &brightness); - break; + return; case WMI_EVENT_PERFORMANCE_PLAN: blocking_notifier_call_chain(&bitland_notifier_list, BITLAND_NOTIFY_PLATFORM_PROFILE, NULL); - break; - - case WMI_EVENT_OPEN_APP: - case WMI_EVENT_CALCULATOR_START: - case WMI_EVENT_BROWSER_START: { - guard(mutex)(&data->lock); - if (!sparse_keymap_report_event(data->input_dev, - event->event_id, 1, true)) - dev_warn(&wdev->dev, "Unknown key pressed: 0x%02x\n", - event->event_id); - break; - } + return; /* * The device has 3 fans (CPU, GPU, SYS), @@ -783,6 +843,14 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev, */ case WMI_EVENT_CPU_FAN_SPEED: case WMI_EVENT_GPU_FAN_SPEED: + /* Redmi refresh rate toggle quirk */ + if (event->event_id == WMI_EVENT_CPU_FAN_SPEED && + event->value_low == 0 && event->value_high == 0) { + payload = BI_HOTKEY_CODE(WMI_EVENT_REFRESH_RATE, 0, 0); + bitland_mifs_wmi_report_key(wdev, payload); + return; + } + if (event->event_id == WMI_EVENT_CPU_FAN_SPEED) fan_data.channel = 0; else @@ -793,27 +861,14 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev, blocking_notifier_call_chain(&bitland_notifier_list, BITLAND_NOTIFY_HWMON, &fan_data); - break; - - case WMI_EVENT_AIRPLANE_MODE: - case WMI_EVENT_TOUCHPAD_STATE: - case WMI_EVENT_FNLOCK_STATE: - case WMI_EVENT_KBD_MODE: - case WMI_EVENT_CAPSLOCK_STATE: - case WMI_EVENT_NUMLOCK_STATE: - case WMI_EVENT_SCROLLLOCK_STATE: - case WMI_EVENT_REFRESH_RATE: - case WMI_EVENT_WIN_KEY_LOCK: - /* These events are informational or handled by firmware */ - dev_dbg(&wdev->dev, "State change event: id=%d value=%d\n", - event->event_id, event->value_low); - break; + return; default: - dev_dbg(&wdev->dev, "Unknown event: id=0x%02x value=0x%02x\n", - event->event_id, event->value_low); break; } + + payload = get_unaligned_le32(buffer->data); + bitland_mifs_wmi_report_key(wdev, payload); } static const struct wmi_device_id bitland_mifs_wmi_id_table[] = { -- 2.55.0