From: Samiullah Khawaja <skhawaja@google.com>
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
Mike Rapoport <rppt@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
Alexander Graf <graf@amazon.com>
Cc: Samiullah Khawaja <skhawaja@google.com>,
David Matlack <dmatlack@google.com>,
tarunsahu@google.com, open list <linux-kernel@vger.kernel.org>,
"open list:KEXEC HANDOVER (KHO)" <kexec@lists.infradead.org>,
"open list:KEXEC HANDOVER (KHO)" <linux-mm@kvack.org>
Subject: [RFC PATCH 6/6] iommufd/selftests: Preserve all the FDs in a batch
Date: Thu, 1 Oct 2026 00:57:34 +0000 [thread overview]
Message-ID: <20261001005734.1033516-7-skhawaja@google.com> (raw)
In-Reply-To: <20261001005734.1033516-1-skhawaja@google.com>
Use the luo_session_preserve_fds() to preserve vfio cdev, iommufd and
memfd together in a batch.
Signed-off-by: Samiullah Khawaja <skhawaja@google.com>
---
.../iommu/iommufd_liveupdate_kexec_test.c | 27 ++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/iommu/iommufd_liveupdate_kexec_test.c b/tools/testing/selftests/iommu/iommufd_liveupdate_kexec_test.c
index 26c7e15b6187..3ce282fc1a33 100644
--- a/tools/testing/selftests/iommu/iommufd_liveupdate_kexec_test.c
+++ b/tools/testing/selftests/iommu/iommufd_liveupdate_kexec_test.c
@@ -153,6 +153,9 @@ static void setup_iommufd(int iommufd, int memfd, int cdev_fd)
static void before_kexec(int luo_fd)
{
int iommufd, cdev_fd, memfd, session;
+ __u64 tokens[3];
+ __u32 failed;
+ int fds[3];
create_state_file(luo_fd, state_session, STATE_TOKEN, /*next_stage=*/2);
@@ -174,9 +177,27 @@ static void before_kexec(int luo_fd)
if (!luo_session_preserve_fd(session, iommufd, IOMMUFD_TOKEN))
fail_exit("Preserving iommufd without memfd should fail");
- test_luo_session_preserve_fd(session, memfd, MEMFD_TOKEN);
- test_luo_session_preserve_fd(session, iommufd, IOMMUFD_TOKEN);
- test_luo_session_preserve_fd(session, cdev_fd, CDEV_TOKEN);
+ /*
+ * Batch without iommufd: memfd is preserved first, then cdev fails.
+ * The whole batch must be rolled back, including the memfd.
+ */
+ fds[0] = cdev_fd;
+ tokens[0] = CDEV_TOKEN;
+ fds[1] = memfd;
+ tokens[1] = MEMFD_TOKEN;
+ if (!luo_session_preserve_fds(session, fds, tokens, 2, &failed))
+ fail_exit("Batch preserve without iommufd should fail");
+ ksft_assert(failed == 0);
+
+ /* Full batch, passed in reverse dependency order. */
+ fds[0] = cdev_fd;
+ tokens[0] = CDEV_TOKEN;
+ fds[1] = iommufd;
+ tokens[1] = IOMMUFD_TOKEN;
+ fds[2] = memfd;
+ tokens[2] = MEMFD_TOKEN;
+ if (luo_session_preserve_fds(session, fds, tokens, 3, &failed))
+ fail_exit("Batch preserve failed at index %u", failed);
close(session);
session = luo_create_session(luo_fd, iommufd_session);
--
2.56.0.rc1.315.gc6ed9934b7-goog
next prev parent reply other threads:[~2026-10-01 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 0:57 [RFC PATCH 0/6] Introduce file handler dependency level Samiullah Khawaja
2026-10-01 0:57 ` [RFC PATCH 1/6] liveupdate: " Samiullah Khawaja
2026-10-01 0:57 ` [RFC PATCH 2/6] mm/memfd_luo: Set Liveupdate level of a memfd file handler Samiullah Khawaja
2026-10-01 0:57 ` [RFC PATCH 3/6] iommufd: Set liveupdate file handler level Samiullah Khawaja
2026-10-01 0:57 ` [RFC PATCH 4/6] vfio/pci: Set live update " Samiullah Khawaja
2026-10-01 0:57 ` [RFC PATCH 5/6] selftests/liveupdate: Add API to preserve a batch of FDs Samiullah Khawaja
2026-10-01 0:57 ` Samiullah Khawaja [this message]
2026-10-04 17:21 ` [RFC PATCH 0/6] Introduce file handler dependency level Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001005734.1033516-7-skhawaja@google.com \
--to=skhawaja@google.com \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=tarunsahu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®