From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D7743498B for ; Thu, 1 Oct 2026 05:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790832250; cv=none; b=sGu5A9kEkD9u2lbqcMzzk7VFGh/JaEIWR0eiywoI/3/lcZb9JPTCex7WhcxihYu2+MSPdeV7NY9LeNAgLmWtiyXn8C6KWhnjqJIkJF6nfBqfvxx86Th9MANfp07xR35yqZLCl76O0ukqGnjSUumVh3hp3XGCI02gA183gV2/zr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790832250; c=relaxed/simple; bh=Tr7tAKiVKAx+CiKpmUJ0G5oOvXKJSNwK5ZsS3+Oo3+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LiWEg2jY8/bXJ3IZP/xaVgkhjLjN1YF+cHOuPkGF+v6YSKRj4o6sGMH6yTbSigG3YfDu4UbXAbKjfad0C5QQBaPLm1fANfje2p5+t5boEwDFtYAHMxJKJnQROiUq7k3t9xL9FEUhpzQsegnBeHAGnGcV1hXHSEY2nAjnWoXWHas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pzKcGLko; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iLFi7pPM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pzKcGLko"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iLFi7pPM" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6913g2WX1509997 for ; Thu, 1 Oct 2026 05:24:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hdmJBOURZFk lDL2G+CgifetZhhumtO7AZp3GzGIPueQ=; b=pzKcGLkoAGuQyphMlTQGjDL5nHr RUGVSK6PwFnL6jcgXJvVsOhumo6LKovj/FJEiwMafqQVd6NaxgJ2Ux3FiYWYL6l0 0xjszU2WBrX0xs2CzpRtdIIrIw8Ca4zkF5kPuipwyLZpfOvF4RM3u2QSkG3h+4xk ctfVyXKIFmQI2n4iaMFaU0CT4DYUN7dbPLmtZ/hjLsKbovmRZogqzGeQwt9Nlzke ZJptSenFJBxmbZQMtu+oaiNM7zp10QNaqQrpIxKnrHeRFwlRfW2iImiy+UsToqHY XnS7Ebnr2OQvKoWT7kLy25FN2FSl7HB71ZKAsFJPdzsxrlsvGw2G+/kQ6tA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h10bkca0r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 01 Oct 2026 05:24:05 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2db8c152622so40747395ad.2 for ; Wed, 30 Sep 2026 22:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790832244; x=1791437044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hdmJBOURZFklDL2G+CgifetZhhumtO7AZp3GzGIPueQ=; b=iLFi7pPMt1Zp4xxI2L3BPD8OODy/qlcMjL+ZZiW+7ahtaGSEMnIQsbEHwqGHx3FXp7 fEtcd/dKcjJ/+NIB7IAXltIVggg3ODTSi77P338jqYxmBeezViTiDMAHGGYkqOz7hDHN UAMEEdbxxeRtEYXs4kxhinLtOObcFg2g2zrr1h8L3xzxUeQmdzCD49sn1Fb9lSS4hfXm N9T3Myn2iY1+SV3aqq3E3wTTILhvgUW4DJG/n4rYV+M3Cx3zns5QezHM17Et+57fqgMo c31rD9EpEF/RCJzVNi08HNNknuaWB6K+ZJUYus4qbUNcqOiq1yb+9fYNOcVec9s36S7t 4ltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790832244; x=1791437044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hdmJBOURZFklDL2G+CgifetZhhumtO7AZp3GzGIPueQ=; b=zwiPc/V9GgOUhST6sj1HvNqINYH+pRjXjvimYRoZoo9YOqNIZffz/bQuJEKBxGmXwp 14Ptl061cePgmQqfMx6W/PfBqYkf/YZA5BSui4vYxtPs2MlGIHcOGRJlAxt0TKdksplq CCs9DlVU5JsXRDZZcfqfRx5XEUFB7bPCXw4bt/ViEm6Z4D/RfUrSc5CKKvaeJ9cb+c24 abLzxKQ7IRYbdr01obCkVcVRUA1iBziKgADBdjG4Ssht6U/fS/gsdc5+9fZfVINnvP3n vO4poy/XwOZVgi+J2IH23YyOhcJxGvVxpX2bCAa7UoPePv3I6/DWQvFKDjrj/Bhem5mX ZIag== X-Forwarded-Encrypted: i=1; AKwUvByllatnR1gU4nRogHcGCqYZootdatNCZpDDyaCgx2vqsgWPOOrQj/ArdjxLWSlvr0WcGnjsRZV95DY+OkA=@vger.kernel.org X-Gm-Message-State: AFq9FYIwMaqbapiyDak33ors8gzYjN0DNtayWw3uSe0QHfvPlqqjvA46 SbRTqcOdEatzuB4MyR6ya+IQ+qUmivv3oFY/q/70glVDNnL64+awDSwRx1mojn0CcVTezfOMM20 eB7GCSs064Y5W8gsiDZgtUpsD5MrVhaxK8qM0ZG24m+WN32gK8rppSf3niUEnKDv8nZ4= X-Gm-Gg: AYBFou20NIh+RRXGN1Ls7sAbHU14YeW0IJwXbAVKATxxarOrt/fGyQUVw95jfmav40p 8UcUn3CPKrGRoBQhKIzZuHMj3p2iev6OVQM+ZE+UQO8KYur5EGj6GppXzhRChfI0i1xwfYkbLpY AOUSyRc7oGRxP4yOjpySPoleVjB9YegHtcxhSTD7b4oriL/GrBXmBO6STWMhZdD7yvQ1u6eWMkb f3ZmV8d7XSa3S+Ajmkbyv0c2qREYuAQ+2urBNvXbVuBkuzkGG8qAlN1R705yASaFCdK/wEmkOZY B/eKBqprwcg2BYf2TMS2tksA5zIs/EvuuRMJTvMxQVTaNZ8WZrlHAGfA+zPo/UYgupAQGHoeAOj HARshxt2h9GZKehaSHWQxeD9bxj0uGGDdC+KeRHfb8m9zuc//8swriNxklY4+aPpaNkIPkzssYp akOjN/qBAT8Bgwt8HtReAjoF5j X-Received: by 2002:a17:902:d489:b0:2e2:c2a6:48bf with SMTP id d9443c01a7336-2e2e4b33993mr27534075ad.26.1790832244446; Wed, 30 Sep 2026 22:24:04 -0700 (PDT) X-Received: by 2002:a17:902:d489:b0:2e2:c2a6:48bf with SMTP id d9443c01a7336-2e2e4b33993mr27533625ad.26.1790832243901; Wed, 30 Sep 2026 22:24:03 -0700 (PDT) Received: from hu-mchitale-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2e300b851b9sm5152715ad.78.2026.09.30.22.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 22:24:03 -0700 (PDT) From: Mayuresh Chitale To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Greg KH , Alexander Shishkin , Ian Rogers Cc: Mayuresh Chitale , Alexandre Ghiti , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Jiri Olsa , Adrian Hunter , Mayuresh Chitale , Anup Patel , Atish Patra , Andrew Jones , Sunil V L , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Anup Patel , Zane Leung Subject: [PATCH v6 05/14] gtrace: Add functions to start/stop tracing on a component path Date: Thu, 1 Oct 2026 10:52:16 +0530 Message-ID: <20261001052243.3042627-6-mayuresh.chitale@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261001052243.3042627-1-mayuresh.chitale@oss.qualcomm.com> References: <20261001052243.3042627-1-mayuresh.chitale@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: wrBeb1r522Z7pzqDLEHb--EO1-j-RNIn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDAxMDAyMSBTYWx0ZWRfX/UJ74KcapFCE qnykcynzxBZLpLc/T8TzIMu3RITG1zBX4oKpz5lQGXP5B1Aj5quB3nlB6YPINtojPvV0nQK7pRu bNad4/dsEwJDtNKu+bcYXj7d3yJVUj4lA2a79etb78WTzNCcxFvbAoZllNuU+C3uBvkCrdVDsPv yjuM+wpce8FoQaFhr5ha2pUz5f+baw23UFxFvRAnrb216RhOQe3O+xTPTy5G2t4a4TFWa5MTik1 2Y4IgLCVgHOvmGJA8Wf0fNbGf9EU9BU1lxyIKnKfs1fRpLUSmYOEI1+mWW6S94uoHmdHH4OtYvb C/RTFiEDQ8JdX1Zf43RVrhpoXCzBGnuUe6QJACIMJjBeC1R56sZLUVsZ8DIiff/hT73+B3gun0m 7a56moyoJG/uOTaL9vSFc6Dpzdqa1AaW0ENqZJTJpdA5Jpo4r3p+8CYCtGa3+gkMRUELELSyERT YXLWm1eNFlsJWT+sAWQ== X-Authority-Analysis: v=2.4 cv=MZn5KJ/f c=1 sm=1 tr=0 ts=6abdee75 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Be7mbbALSbNoa8F8jQ8A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDAxMDAyMSBTYWx0ZWRfX82pYUY69JKm6 NxFNRYXaTKjmDNIzTF6Ek2QTa1FAwNIz/0L8a1x5SZ1aXiT9Aka1Wm2/E1com/RlOZJDlfgDQpW e8eUj1tsR3ePKreLfvGoDJsrzJ1eFWg= X-Proofpoint-ORIG-GUID: wrBeb1r522Z7pzqDLEHb--EO1-j-RNIn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-01_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610010021 The perf driver framework needs to be able to start / stop all components in a trace component path during its operation. Add gtrace_path_start() and gtrace_path_stop() functions for this purpose. Co-developed-by: Anup Patel Signed-off-by: Anup Patel Signed-off-by: Mayuresh Chitale --- drivers/hwtracing/gtrace/gtrace-core.c | 104 +++++++++++++++++++++++++ include/linux/gtrace.h | 7 ++ 2 files changed, 111 insertions(+) diff --git a/drivers/hwtracing/gtrace/gtrace-core.c b/drivers/hwtracing/gtrace/gtrace-core.c index f750025104ec..d7f1df90aa31 100644 --- a/drivers/hwtracing/gtrace/gtrace-core.c +++ b/drivers/hwtracing/gtrace/gtrace-core.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include @@ -24,7 +25,15 @@ static DEFINE_PER_CPU(struct gtrace_component *, gtrace_cpu_source_comp); /* gtrace comp specific data, to be used by core functions only */ struct gtrace_comp_priv { struct gtrace_component comp; + /* + * Protects start_count and owner. Serializes start/stop against other paths + * sharing this component and, for a sink, against gtrace_path_copyto_auxbuf(). + * Raw because the PMU start/stop callbacks are called with the rq_lock held. + */ + raw_spinlock_t lock; u32 type_idx; + u32 start_count; + pid_t owner; bool ready; bool visited; }; @@ -418,6 +427,7 @@ struct gtrace_component *gtrace_register_component(struct gtrace_component_id *i ret = -ENOMEM; goto err_out; } + raw_spin_lock_init(&cpriv->lock); comp = &cpriv->comp; comp->pdata = pdata; comp->id = *id; @@ -611,6 +621,100 @@ static void gtrace_release_path_nodes(struct gtrace_path *path) } } +static int __gtrace_comp_start(struct gtrace_component *comp, pid_t owner) +{ + struct gtrace_comp_priv *cpriv = to_gtrace_comp_priv(comp); + const struct gtrace_driver *gtdrv = to_gtrace_driver(comp->dev.driver); + unsigned long flags; + int ret = 0; + + if (!gtdrv) + return -ENODEV; + + raw_spin_lock_irqsave(&cpriv->lock, flags); + if (cpriv->start_count) { + if (cpriv->owner != owner) { + ret = -EBUSY; + goto out; + } + } else { + if (gtdrv->start) { + ret = gtdrv->start(comp); + if (ret) + goto out; + } + cpriv->owner = owner; + } + + cpriv->start_count++; +out: + raw_spin_unlock_irqrestore(&cpriv->lock, flags); + return ret; +} + +static int __gtrace_comp_stop(struct gtrace_component *comp) +{ + struct gtrace_comp_priv *cpriv = to_gtrace_comp_priv(comp); + const struct gtrace_driver *gtdrv = to_gtrace_driver(comp->dev.driver); + unsigned long flags; + int ret = 0; + + raw_spin_lock_irqsave(&cpriv->lock, flags); + if (!cpriv->start_count) { + ret = -EINVAL; + goto out; + } + + cpriv->start_count--; + if (!cpriv->start_count) { + if (!gtdrv) { + ret = -ENODEV; + goto out; + } + + if (gtdrv->stop) + ret = gtdrv->stop(comp); + } +out: + raw_spin_unlock_irqrestore(&cpriv->lock, flags); + return ret; +} + +int gtrace_path_start(struct gtrace_path *path) +{ + struct gtrace_path_node *node; + int ret = 0; + + list_for_each_entry_reverse(node, &path->comp_list, head) { + ret = __gtrace_comp_start(node->comp, path->owner); + if (ret) + break; + } + + /* If a component failed to start, stop all the components that were started before it */ + if (ret) + list_for_each_entry_continue(node, &path->comp_list, head) + __gtrace_comp_stop(node->comp); + + return ret; +} +EXPORT_SYMBOL_GPL(gtrace_path_start); + +int gtrace_path_stop(struct gtrace_path *path) +{ + struct gtrace_path_node *node; + int ret = 0, err; + + list_for_each_entry(node, &path->comp_list, head) { + err = __gtrace_comp_stop(node->comp); + if (err && !ret) + ret = err; + } + + return ret; +} +EXPORT_SYMBOL_GPL(gtrace_path_stop); + struct gtrace_path *gtrace_create_path(struct gtrace_component *source, struct gtrace_component *sink, enum gtrace_component_mode mode) diff --git a/include/linux/gtrace.h b/include/linux/gtrace.h index 2c3be4d161c6..a4b99c87d250 100644 --- a/include/linux/gtrace.h +++ b/include/linux/gtrace.h @@ -254,6 +254,7 @@ struct gtrace_path { enum gtrace_component_mode mode; u32 trace_id; #define GTRACE_INVALID_TRACE_ID 0 + pid_t owner; }; struct gtrace_component *gtrace_path_source(struct gtrace_path *path); @@ -262,10 +263,14 @@ struct gtrace_path *gtrace_create_path(struct gtrace_component *source, struct gtrace_component *sink, enum gtrace_component_mode mode); void gtrace_destroy_path(struct gtrace_path *path); +int gtrace_path_start(struct gtrace_path *path); +int gtrace_path_stop(struct gtrace_path *path); /** * struct gtrace_driver - Representation of a trace driver. * @id_table: Table to match components handled by the driver. + * @start: Callback to start tracing. + * @stop: Callback to stop tracing. * @probe: Driver probe() function. * @remove: Driver remove() function. * @get_trace_id: Get/allocate a trace ID. @@ -274,6 +279,8 @@ void gtrace_destroy_path(struct gtrace_path *path); */ struct gtrace_driver { const struct gtrace_component_id *id_table; + int (*start)(struct gtrace_component *comp); + int (*stop)(struct gtrace_component *comp); int (*probe)(struct gtrace_component *comp); void (*remove)(struct gtrace_component *comp); int (*get_trace_id)(struct gtrace_component *comp, -- 2.43.0