From: Rosen Penev <rosenp@gmail.com>
To: linux-clk@vger.kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] clk: mmp2-audio: add missing PM_CLK dependency
Date: Wed, 30 Sep 2026 22:23:43 -0700 [thread overview]
Message-ID: <20261001052343.17966-1-rosenp@gmail.com> (raw)
pm_clk_suspend() and pm_clk_resume() are used but a PM_CLK dependency is
needed to expose them as actual functions. Otherwise they are defined as
NULL, which does not work with functions having parameters. NULL is
probably used as these functions are normally passed as function
pointers.
While here, convert the block from spaces to tabs so it matches the
surrounding Kconfig style.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202610010151.2W0MrmxE-lkp@intel.com/
Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/clk/Kconfig | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index d035f2dbecae..9789b2dae51e 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -463,11 +463,12 @@ config COMMON_CLK_MMP2
Support for Marvell MMP2 and MMP3 SoC clocks
config COMMON_CLK_MMP2_AUDIO
- tristate "Clock driver for MMP2 Audio subsystem"
- depends on COMMON_CLK_MMP2 || COMPILE_TEST
- select COMMON_CLK_MMP
- help
- This driver supports clocks for Audio subsystem on MMP2 SoC.
+ tristate "Clock driver for MMP2 Audio subsystem"
+ depends on COMMON_CLK_MMP2 || COMPILE_TEST
+ depends on PM_CLK
+ select COMMON_CLK_MMP
+ help
+ This driver supports clocks for Audio subsystem on MMP2 SoC.
config COMMON_CLK_BD718XX
tristate "Clock driver for 32K clk gates on ROHM PMICs"
--
2.55.0
next reply other threads:[~2026-10-01 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 5:23 Rosen Penev [this message]
2026-10-02 15:18 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001052343.17966-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®