From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: "Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Marcos Paulo de Souza" <mpdesouza@suse.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Fushuai Wang" <wangfushuai@baidu.com>,
"Kees Cook" <kees@kernel.org>,
"Stepan Ionichev" <sozdayvek@gmail.com>,
linux-serial@vger.kernel.org,
"Manuel Lauss" <manuel.lauss@gmail.com>,
linux-kernel@vger.kernel.org, "Petr Mladek" <pmladek@suse.com>
Subject: [PATCH v3 0/1] braille: nbcon: Fix Braille console for NBCON API
Date: Thu, 1 Oct 2026 11:39:45 +0200 [thread overview]
Message-ID: <20261001093946.112999-1-pmladek@suse.com> (raw)
Hi,
this is v3 patch which tries to fix Braille console driver to work
with serial console drivers ported to NBCON API.
I played with the locking. And I came up with another look.
I tried to simulate the legacy locking using the NBCON API.
IMPORTANT: I believe that it should work even in PREEMPT_RT
because it worked with the legacy serial console drivers
there. I think that it works because:
+ con->device_lock() is using normal spin_lock, aka rt_spin_lock().
It should be safe in the VT context even in IRQ context.
+ The VT code can be called from the legacy loop when the related
ttyX is registered as a console. But the legacy loop is offloaded
to a dedicated kthread in PREEMT_RT. So, it will never be called
in a truly atomic context there, except for panic().
Changes against v2:
+ Use con->device_lock() for non-panic case. Try even an unsafe
acquire in panic(). This simulates the legacy locking using
NBCON API.
+ Return when the nbcon context can't be acquired in panic().
The NBCON API is not ready to ignore the lock. Well, it
should never happen in practice because the unsafe acquire...
+ Avoid the newline prepend logic in all serial consoles
ported to NBCON API which have it. Add two APIs for
checking whether either "con" or "wctxt" is in Braille
mode.
+ Update commit message and comments in the code.
Changes against v1:
+ Merged into one patch. It is hard to explain nbcon_braille*()
API without the user.
+ Reworked the locking, see the commit message for more details.
+ Fixed the check of CON_NBCON_ATOMIC_UNSAFE [Sashiko]
IMPORTANT: The solution is not safe in PREEMPT_RT. But it is better
then nothing. We could either solve it in v3. Or we could
fix it later.
[v1] https://lore.kernel.org/r/20260922072558.98854-1-pmladek@suse.com
[v2] https://lore.kernel.org/r/20260925141729.173943-2-pmladek@suse.com
Petr Mladek (1):
braille: nbcon: Allow to use a serial console with NBCON API as
Braille console
.../accessibility/braille/braille_console.c | 64 ++++++++++++++-
drivers/tty/serial/8250/8250_port.c | 5 +-
drivers/tty/serial/amba-pl011.c | 2 +-
drivers/tty/serial/imx.c | 2 +-
drivers/tty/serial/sifive.c | 2 +-
include/linux/console.h | 15 ++++
kernel/printk/nbcon.c | 78 +++++++++++++++++++
7 files changed, 162 insertions(+), 6 deletions(-)
--
2.55.0
next reply other threads:[~2026-10-01 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 9:39 Petr Mladek [this message]
2026-10-01 9:39 ` [PATCH v3 1/1] braille: nbcon: Allow to use a serial console with NBCON API as Braille console Petr Mladek
2026-10-01 10:48 ` John Ogness
2026-10-01 12:01 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001093946.112999-1-pmladek@suse.com \
--to=pmladek@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=mpdesouza@suse.com \
--cc=rostedt@goodmis.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=senozhatsky@chromium.org \
--cc=sozdayvek@gmail.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®