From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl2-f7.google.com (mail-dl2-f7.google.com [74.125.229.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6624A8A3C for ; Thu, 1 Oct 2026 10:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.135 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790849032; cv=none; b=DT0ijy59c8omfL1aRbKQpGLhfbmuqe2Pi0EhifQa1KLDy5UT32/IIqXs070A+KbxNSgiSkVW/HbHuRlZSnkIGHDCBkCQdJoeQVWygwetjsKTnzCD7HCGDxRTAnnRP8Do/FbAqZLQwh8yJ2d4Z+vK4LvdSNOBxTpj5Zks4rDFVwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790849032; c=relaxed/simple; bh=VaIpTDJD6b0O9LgfdThrs/rsgDOAu7oastbAMYStvxM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iU0xSbh+hPczFWGsYkJhCXtUOFSH//deBJk3BpxvNpqBn6fc4lm4lg0sTzDR7GO6ZLEwjrBtPjr+Splo/8oDK6fQFWNPRbi6ysKHEQhPY8omEQQkVVeXoo6lk5sVMy56k7IRPWlg78QH/xQSMXq/M37rX+NRJNzxQ1sRcGXAuRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MgynxTyr; arc=none smtp.client-ip=74.125.229.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MgynxTyr" Received: by mail-dl2-f7.google.com with SMTP id a92af1059eb24-139b659a45eso1097972c88.1 for ; Thu, 01 Oct 2026 03:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790849030; x=1791453830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=84WGXPG5BWnhkDA0xLnGT3XuLYOG0uz1Te11KxmlCVA=; b=MgynxTyrTwmry5Nkpa3tBiH4GJlNgXhQCtFXPZrNmD0YsI13gPoc1qtCcHRZZWq5vd 5kkIY9whZRrPuXixks/sSdTt/j+TDamMD/Onql6LnwVr7DPF6VYJCuUD9gpUZEloYF0M z+pPzbSQZDpVAhy7L1KWVHiNlK8IOroCVTDEHJ+qJ8tlVHtQndNulNbmDgSpxvpoZG1X bYO0WvBfAzh7/vyTlI3XKV6w/iBrMu0JCIEmCiT4tQ7esrZwPfvDWCbM7PeC7r9u5TYL 2VF5SnqRh9SHkFC7T1EWgbYusNELzGreevAeEb1ZznfmBaHHU28ukWvxstYkYqHxauV7 eIaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790849030; x=1791453830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=84WGXPG5BWnhkDA0xLnGT3XuLYOG0uz1Te11KxmlCVA=; b=uIfjiOcnaY6GxE5UFgfER1UXprjEKZeTzVFCs2/jYy/QCw45ldZ1k12HdLG0KHmA01 KkZiROM4WDkIZsMV5jpKHpBpsDEBeExFH7TaX225wPA7EYECExJKVc0PoCRmQ+2DdrDS y76VAHeOYIZR+IfwyaYSsStRJfkgNJf7otas0woMDyxAhP1zsMKF9YcG9XlXu6ThFovh QZ6fKWIdCRpKBcNUflCLDlDsb638vIZjGvm4aA4GFYJW0mliTwZaBf4CfFCM562qafpT DKCnsYbq0w9ZwlzBJSBLkBs3mE9yYn8EnnKdZBKtveo0hI1ssN33piootK1cqnJGFTzA K9Ig== X-Forwarded-Encrypted: i=1; AKwUvBzNsv97Kba3WnzeLez6kYcuKNepoHaOorWcNfKi9XHDMIDJiTPpmDLWOTAzgQERUW9JtvA5dksBwIFTESA=@vger.kernel.org X-Gm-Message-State: AFuF++kYCYZNuFaePoG0jtRkpn0eR3OVDn1LwRQPpBwVm+dAn6lCUKQP epxuP5GUoBNIFABSHddpi5DhWKzDh1xWRfCVi0DiEjBuAEY8EsKsGIlW X-Gm-Gg: AYBFou15fGSe6eQh/VT5zaRpopSvvO6I/u//9tMAZ2hd1C2ptYr/g5EHhhhp+gVaW1c BR9EJp1xLFG+OgjJX8ayPvzVgrqipqFzbRfycLMfrS/+ggxYd4X56DVPVR6p1ki4WMXUuaEjKl7 mwl4g0LzzBD+oF2vXng8+3l65ma85ssvw31GjvIMIFg2GG3ZJ7ePg10MS63TatEKpktlkLPvyQ6 nT5aQsjkApBQeV+4ZbgdeW238j8MiyMIYHqBJ8ddDNF4WAgX9mLvzePCNnaPCJ9M/6kk90zy65z nIIrBr4mCgah3gaJVoI0dpkBqqAYdtVajzd+cTwjKS0doeRVQLC6F1k77Qm92xmjla6fb2nIuao d9HYMRc2lCZU6TR3DBTbJfii9RQvpl+f2r1O0VrxMhY0SBHkBi+jMXezGiQIdLECADqkySvUhnJ ey5DK1p3FkmZTKw27tir6RfGvB4N5bPuvd+yJGqXp4fYzjJkVvWN3I2yFPscbs7og23lOZZqDWe vSJRr2gGKPb6R662aBPE94farM= X-Received: by 2002:a05:7022:424:b0:148:80d4:84ac with SMTP id a92af1059eb24-14d331aae41mr5590017c88.29.1790849029785; Thu, 01 Oct 2026 03:03:49 -0700 (PDT) Received: from localhost.localdomain ([98.148.34.5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14df359f15asm5537305c88.4.2026.10.01.03.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 03:03:48 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2] staging: rtl8723bs: use errno in rtw_register_tx_alive() Date: Thu, 1 Oct 2026 10:03:19 +0000 Message-ID: <20261001100319.6228-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtw_register_tx_alive() uses the driver-specific _SUCCESS and _FAIL values to report whether the transmit path can continue. Use the usual kernel convention of returning 0 on success and -EAGAIN when the transmit path cannot proceed yet. Update the caller accordingly. No functional change. Signed-off-by: Hungyu Lin --- Changes in v2: - Use the standard 0/-errno return convention instead of bool, as suggested by Greg. - Return -EAGAIN when the transmit path cannot proceed yet. drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 13 ++++++------- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 +-- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index 448611ad8237..00d64b2ff89e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -771,13 +771,12 @@ void rtw_unregister_task_alive(struct adapter *padapter, u32 task) * _SUCCESS rtw_xmit_thread can write fifo/txcmd afterwards. * _FAIL rtw_xmit_thread can not do anything. */ -s32 rtw_register_tx_alive(struct adapter *padapter) +int rtw_register_tx_alive(struct adapter *padapter) { - s32 res; + int ret = 0; struct pwrctrl_priv *pwrctrl; u8 pslv; - res = _SUCCESS; pwrctrl = adapter_to_pwrctl(padapter); pslv = PS_STATE_S2; @@ -788,7 +787,7 @@ s32 rtw_register_tx_alive(struct adapter *padapter) if (pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm < pslv) { if (pwrctrl->cpwm < PS_STATE_S2) - res = _FAIL; + ret = -EAGAIN; if (pwrctrl->rpwm < pslv) rtw_set_rpwm(padapter, pslv); } @@ -796,11 +795,11 @@ s32 rtw_register_tx_alive(struct adapter *padapter) mutex_unlock(&pwrctrl->lock); - if (res == _FAIL) + if (ret) if (pwrctrl->cpwm >= PS_STATE_S2) - res = _SUCCESS; + ret = 0; - return res; + return ret; } /* diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index 0441e84ea87d..77e5adc8731e 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -140,9 +140,8 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter) return _SUCCESS; ret = rtw_register_tx_alive(padapter); - if (ret != _SUCCESS) { + if (ret) return _SUCCESS; - } do { queue_empty = rtl8723_dequeue_writeport(padapter); diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h index 49f19b6ee329..a14da6c18201 100644 --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h @@ -217,7 +217,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter); s32 rtw_register_task_alive(struct adapter *adapter, u32 task); void rtw_unregister_task_alive(struct adapter *adapter, u32 task); -s32 rtw_register_tx_alive(struct adapter *padapter); +int rtw_register_tx_alive(struct adapter *padapter); void rtw_unregister_tx_alive(struct adapter *padapter); s32 rtw_register_cmd_alive(struct adapter *padapter); void rtw_unregister_cmd_alive(struct adapter *padapter); -- 2.43.0