From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a5-smtp.messagingengine.com (flow-a5-smtp.messagingengine.com [103.168.172.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9FD5208B0 for ; Thu, 1 Oct 2026 17:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790876386; cv=none; b=JenvXJDeMVNxun+WW6rXIhIiM1qVe4ifKuaRRUdl5ijBvHl6T5qUr5lHxqLt2TZ6UmSkSVRJ2pksu5Yw453ZC11CbQi68m1J4aRMd85BTyZuxSeejrlLDUMlOMUhq1Yl4Fwr6sdEGePwII+jfHC8JRRyhx9tIpQsvsDwgYr3b5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790876386; c=relaxed/simple; bh=dK1YC8FLSUXxmYfSB8ouUVvYnUfdNVfIde9XouOn+8A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bU7ws1ggZKowA4oyuEdzqn4mI+/YnHLMv0d19s6TehThCca4zJf01H8LpUDmCnW9cAYb4bVyUHYQJt1FjzKNGA6gDCay4ESIEdZMkPfVk4syTQ32yBH1tNZyi+0FQvi9mBvxXI8ebUn+UEPNvrFTH7iEgexHhq15n7PiC9mHLp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=kdqSq7ON; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tFtwlagK; arc=none smtp.client-ip=103.168.172.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="kdqSq7ON"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tFtwlagK" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailflow.phl.internal (Postfix) with ESMTP id 9608113803E2 for ; Thu, 1 Oct 2026 13:39:41 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Thu, 01 Oct 2026 13:39:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1790876381; x=1790883581; bh=l3aq13J5VX9YHBy+nDgiTWl41JHuJfuq9o7FqdgtotQ=; b= kdqSq7ONSi0lCoc73xVfCf0+TFUtGLQ7rPztnEBFgqNS25kl0UE2ydYW6SAq4qPz EWwWi6Jw3w67qM11Pa6ILzqkKawDmHle7CyFrKqeweES/L5JDCCwVhoMIoa5Bl+B oNBA1N5QyFADEWk155aFKZ36Id6Fd1jvO5V1LWzvxw/aHqgOva1pi5Fimta6GDxK LY+4xoehiYHkLPXhjjjGVnmdBFYJVPqINy0sIbjR5c4jtmMmW1YKE8d5TKF032zk qUZz+OIzpEI76WdwsE3sPpQ/XNIOpG8SJkrWibuxaUMweE/76B17Wr3PFHTqsLSO QO+AJHyDpFCZYfEtR04sUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1790876381; x= 1790883581; bh=l3aq13J5VX9YHBy+nDgiTWl41JHuJfuq9o7FqdgtotQ=; b=t FtwlagKkqMq92EXRtCIhXFmPZqwc04B6V7Xrod3Y3SE25ilvAQNcvJnHjZSVy7HR 5jdBUNSA3RPIe9XvW/RWSEOxDs1yeROoWR06orhQzf5XQQbZkvFoVfEx4M6jgChW BoDlQSfm9w+b/dhDhe/0ikdEIFaUjz1eMao8lio1sPifIu7AfFTiBQ98oDhQ6o/r n4WLrTOF66O+S5JvVkosjThNjh9kXiVnSXH4CZgen49piBSrHmI09weFPAavVWQq APRPkEx3KV5DQFdpif/qhaMTdZeXIj016XBuQEu5mhLa7zfMxZbJhvTznqrJOJi6 SDM/8jixveElLhdfeOmjQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=sign d=shazbot.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1790876381; d=shazbot.org; mf=PGFsZXhAc2hhemJvdC5vcmc+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm1:rsa-sha256:3YhYBxG2JGkYhIwuDLpuYnvGQJcV6MMzahNgmv3ORXa0f2z epACDNgqQ+dyVAkK4HRLeaAEu9Whqg3Y5hHj1Xm71sagnG1HBAyBGDL1aLDN45XU aA2CoTUt+nh6FDQIrnuIEsbHqsQMy1wGDuf3aqtQaImokCpNuSQEptEHFvJOhcR8 Lb1272szB1z8R5Cfm/rOy2xDr5ufUU5M3P/+FkLHUph8sX9LEzo07zhtagnABJfC qE49DcSq9widLbqNxAYLKGN60b9EZ3480oDpzPq5MKviEKCv0Bo6RWuBxFbr050G MG96OPfogkCZtQ2t5YpjwK9pSZMd4C+oAXXgRHA==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-09-30; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:z2qhpcc+RzePh3dNm2m2+Knepu4wJdsPJN+T/6bVKtY=:dK1YC8FLSUXxmYfSB8ouUVvYnUfdNVfIde9XouOn+8A=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFjMvnoc2ZRA7bRZ4ZKMJykf9Z98u/a2S5rh6yqc8FD4Z2e29OmoZxkc+onHeIyrO dAAb7ujMFpuUmFa0XOLFnfycqmpnr+UIiD5zRwb5uYR2lYv6+v5NCR1bPSqjMBLj2CqaW6 bGfvCIuo5XeKSJoFMuhojzwmrcvpaYASjzwRKcIYro0OeFDAHuRae9leb0cb4m7sBGrsmE jCoOsgcuxYpxueCYXFZedkdKyG59g/H4j/0JzaspL9zC72ImcaIHxOZgPV3I9KXiTG0cHv OKxlOLPWD6+O1841nvrr30eav+R/UAz5An5jQuTZz2zK0mCKezUT+eizpE40cUJR7nRiOC XWlYJHtlaMCbCnJt1eiwOL4U34V7yoz/m0dHBpDTvXhSeHaRsWqKRS+kbBH7Idg8tmSPPg 3dC7joSgHbDzjQWILZ9lklcXyfU32/naPYE5wnfMlCD6FbjI4Mw6i/84fzJLpUrDG2+n5e A/yg01EdAeC08uEihbbzzhS+G/gMlcNShtLuelgSPD1UUbEVM1ikYZyALm7R+52Qvea4eL tlhfdWJrehWohKCYe9EBF44U576JhWbZNUtrD5Ggu8lWSECAs78EGda4MH2XPU9206tRxT BfXUkX3ZM1nndndcQ1wpG/cZBIpmYWliTlcl/KvwvpB30FB4sRJgKyA08t4A X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Oct 2026 13:39:38 -0400 (EDT) Date: Thu, 1 Oct 2026 11:39:36 -0600 From: Alex Williamson To: Steffen Eiden Cc: Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Matthew Rosato , Farhan Ali , Eric Farman , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Holger Dengler , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , alex@shazbot.org Subject: Re: [PATCH v4 4/6] KVM/vfio: Use file-based reference counting for KVM Message-ID: <20261001113936.21bc850a@shazbot.org> In-Reply-To: <20260928-vfio-v4-4-e32e226d5932@linux.ibm.com> References: <20260928-vfio-v4-0-e32e226d5932@linux.ibm.com> <20260928-vfio-v4-4-e32e226d5932@linux.ibm.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 28 Sep 2026 15:07:05 +0200 Steffen Eiden wrote: > diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c > index 423ead48aafe..ed96acfa8635 100644 > --- a/drivers/vfio/vfio_main.c > +++ b/drivers/vfio/vfio_main.c > @@ -472,36 +472,14 @@ void vfio_unregister_group_dev(struct vfio_device *device) > EXPORT_SYMBOL_GPL(vfio_unregister_group_dev); > > #if IS_ENABLED(CONFIG_KVM) > -void vfio_device_get_kvm_safe(struct vfio_device *device, struct kvm *kvm) > +void vfio_device_get_kvm_safe(struct vfio_device *device, struct file *kvm) > { > - void (*pfn)(struct kvm *kvm); > - bool (*fn)(struct kvm *kvm); > - bool ret; > - > lockdep_assert_held(&device->dev_set->lock); > > if (!kvm) > return; > > - pfn = symbol_get(kvm_put_kvm); > - if (WARN_ON(!pfn)) > - return; > - > - fn = symbol_get(kvm_get_kvm_safe); > - if (WARN_ON(!fn)) { > - symbol_put(kvm_put_kvm); > - return; > - } > - > - ret = fn(kvm); > - symbol_put(kvm_get_kvm_safe); > - if (!ret) { > - symbol_put(kvm_put_kvm); > - return; > - } > - > - device->put_kvm = pfn; > - device->kvm = kvm; > + device->kvm = get_file(kvm); > } Nit, retaining the "_safe" naming here and through the callers is now meaningless and could be dropped. Otherwise, Acked-by: Alex Williamson Thanks, Alex