From: Rob Herring <robh@kernel.org>
To: Leo Yan <leo.yan@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: coresight: Allow funnel clocks
Date: Thu, 1 Oct 2026 07:04:44 -0500 [thread overview]
Message-ID: <20261001120444.GA1048975-robh@kernel.org> (raw)
In-Reply-To: <20261001100455.GL14479@e132581.arm.com>
On Thu, Oct 01, 2026 at 11:04:55AM +0100, Leo Yan wrote:
> Hi Rob,
>
> On Mon, Sep 21, 2026 at 06:28:33PM -0500, Rob Herring (Arm) wrote:
> > Some static funnel nodes have APB and AT clocks. Allow one or two
> > clocks and the apb_pclk and atclk clock-names entries.
> >
> > Assisted-by: LLM
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> >
> > ---
> > .../bindings/arm/arm,coresight-static-funnel.yaml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
> > index 9598a3d0a95b..4a3d08f9568c 100644
> > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
> > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
> > @@ -30,6 +30,16 @@ properties:
> > power-domains:
> > maxItems: 1
> >
> > + clocks:
> > + minItems: 1
> > + maxItems: 2
> > +
> > + clock-names:
> > + minItems: 1
> > + items:
> > + - const: apb_pclk
> > + - const: atclk
>
> The question is that a static funnel does not need to program any
> registers, so in theory it should only need atclk as the module's core
> clock, but not the APB programming clock (apb_pclk).
>
> Maybe I did not get this right when I initially enabled the static
> funnel in hi3660-coresight.dtsi. We should probably remove pclk from the
> static funnel node.
Yes. I suppose in theory it has some clock, but if pclk needed to be
enabled, it is shared with all the other coresight components and
enabled anyways. And there's no atclk defined, so 'clocks' can just
be removed. Can you send a patch to do that, and I'll drop this one.
zynq7000 is even more of a mess I just noticed...
Rob
next prev parent reply other threads:[~2026-10-01 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 23:28 Rob Herring (Arm)
2026-09-30 20:41 ` Rob Herring (Arm)
2026-10-01 10:04 ` Leo Yan
2026-10-01 12:04 ` Rob Herring [this message]
2026-10-01 13:41 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001120444.GA1048975-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®