mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: linux-sound@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: core: Make sure to call snd_card_disconnect() at freeing
Date: Thu,  1 Oct 2026 15:18:09 +0200	[thread overview]
Message-ID: <20261001131810.527650-1-tiwai@suse.de> (raw)

When a card object gets freed via devres, it might be freed without
calling snd_card_disconnect(), and it might forget to release some
resources such as the procfs that gets deleted at the disconnect call.

Add an explicit call of snd_card_disconnect() at snd_card_do_free()
for assuring the preparation for cleanup.

Fixes: e8ad415b7a55 ("ALSA: core: Add managed card creation")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

This patch is required as a prerequisite for the recent cleanup series
to use auto-cleanup:
  http://lore.kernel.org/20261001110447.486782-1-tiwai@suse.de

 sound/core/init.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/core/init.c b/sound/core/init.c
index 0897b3a11617..764d3d1073e7 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -564,6 +564,10 @@ static int snd_card_do_free(struct snd_card *card)
 	bool managed = card->managed;
 
 	card->releasing = true;
+
+	/* for case without explicit disconnect call (e.g. via devres) */
+	snd_card_disconnect(card);
+
 #if IS_ENABLED(CONFIG_SND_MIXER_OSS)
 	if (snd_mixer_oss_notify_callback)
 		snd_mixer_oss_notify_callback(card, SND_MIXER_OSS_NOTIFY_FREE);
-- 
2.55.0


             reply	other threads:[~2026-10-01 13:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 13:18 Takashi Iwai [this message]
2026-10-01 15:06 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001131810.527650-1-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®