From: Jakub Kicinski <kuba@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: kris.pan@intel.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, atomasov@redhat.com,
oliver.sang@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: iterate online nodes in skb_defer_free_flush()
Date: Thu, 1 Oct 2026 17:58:33 -0700 [thread overview]
Message-ID: <20261001175833.47968268@kernel.org> (raw)
In-Reply-To: <179081936536.434549.10388925622845161029@kernel.org>
On Thu, 01 Oct 2026 01:49:25 +0000 netdev-bot+sashiko@kernel.org wrote:
> skb_attempt_defer_free() chooses the list without checking whether the
> node is online:
>
> net/core/skbuff.c:skb_attempt_defer_free() {
> ...
> sdn = per_cpu_ptr(net_hotdata.skb_defer_nodes, cpu) + cpu_to_node(my_cpu);
not sure why it says that. There's a check earlier in that function
AFAICT
next prev parent reply other threads:[~2026-10-02 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 1:47 Kris Pan
2026-10-01 1:49 ` netdev-bot+sashiko
2026-10-02 0:58 ` Jakub Kicinski [this message]
2026-10-02 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001175833.47968268@kernel.org \
--to=kuba@kernel.org \
--cc=atomasov@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kris.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®