From: Andrew Morton <akpm@linux-foundation.org>
To: Pedro Falcato <pfalcato@suse.de>
Cc: kernel test robot <lkp@intel.com>,
Josh Law <objecting@objecting.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-mips@vger.kernel.org, Bradley Morgan <brads@mainlining.org>
Subject: Re: arch/mips/boot/compressed/decompress.c:undefined reference to `__ashldi3'
Date: Thu, 1 Oct 2026 18:07:11 -0700 [thread overview]
Message-ID: <20261001180711.b206ee7ab13a1cadafdba4e7@linux-foundation.org> (raw)
In-Reply-To: <ar4050mdKL_W8yI9@pedro-suse.tail5790ac.ts.net>
On Thu, 1 Oct 2026 11:30:09 +0100 Pedro Falcato <pfalcato@suse.de> wrote:
> > - bits |= (bd->inbufBits >> bd->inbufBitCount)&((1 << bits_wanted)-1);
> > + bits |= (bd->inbufBits >> bd->inbufBitCount) & ((1ULL << bits_wanted) - 1);
> >
> > return bits;
> > }
> >
> > 32-bit MIPS should be able to do this?
>
> FWIW the patch seems entirely bogus. I don't think you can have inbufBitCount >=
> 32. If you could, then the patch would still not fix anything, because
> bd->inbufBits is an (32-bit) unsigned int.
>
> As per MIPS itself, MIPS does not link ashldi3.o into the decompressor for BZ2.
> It only does so for XZ and ZSTD.
>
> Changing arch/mips/boot/compressed/Makefile would work, but since the change is
> entirely wrong I would suggest perhaps reverting?
Sure, thanks. Do you have time to send a formal patch?
next prev parent reply other threads:[~2026-10-02 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 16:36 kernel test robot
2026-09-30 19:01 ` Andrew Morton
2026-09-30 19:11 ` Bradley Morgan
2026-10-01 10:30 ` Pedro Falcato
2026-10-02 1:07 ` Andrew Morton [this message]
2026-10-02 9:53 ` David Laight
-- strict thread matches above, loose matches on Subject: below --
2026-07-24 13:33 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001180711.b206ee7ab13a1cadafdba4e7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=brads@mainlining.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=objecting@objecting.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pfalcato@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®