From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4E4F3F7AA8 for ; Thu, 1 Oct 2026 21:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790889665; cv=none; b=CG15Gg0/CUJQgvEFlnQp1mR9KqqGnrrFgn+WaLMcHR9g7jjqboruo2CBh87Yg/qMuWiz4NmaKxt5mpdzhBIgC5xclb3QuAKc63CsgNsABimBcHZBrruclr2xXNz8st29ZpQPcGitGtB37PBmhHnifQ78dJIqjdFU9MVdHftgvXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790889665; c=relaxed/simple; bh=SbI9zuwpLoviGTLgjhQIkxJ0mcfP+lQtKKioVT52hTM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UcD88l8/pfrAmNpIVqhNgyfsJonP544Gz9Ty/vprzqTArrpEkuTrTviDu0qsqPGEwGP2qPKsSDVfpqOw1LRIA732RGNCKa0UsPV1Kv93hkPt4tCo05QCXELJwkXyOJ6X58vsdXXSOFKUjj1nAxh4wcL7TTcibtwKOm228shDl+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rhTvoUaz; arc=none smtp.client-ip=209.85.160.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rhTvoUaz" Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-448d51840c4so6738985fac.1 for ; Thu, 01 Oct 2026 14:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790889661; x=1791494461; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dIr4K7N8tWlFElP154T0gDhZmtv6PLeTBLURDyjAzjU=; b=rhTvoUaz+E+iJsTSARzZw8S6lz4ltoU2dJ9G0gCdDREV7lICxZkfGfK/b+aB80D9QS XQTJSJ10OBersaohxgAAMSwWY8s1ftI7rkEnws4UXcNLgqpaYb1ArpqmACTo3mLaAsmG gdjIaJG3Nbf9Eol4x2BgozJnwNsch3T7oEFcGc48bmP9J1q+GLRS6gjlKTKfYByfCcjT Chw2MPCkNsar6/F3BqrASOUSkacre+/lK4J5YD4K3w75c72KcJ9mASpk7N+rDJBRLBxY 8fR/elkj36oUuTVal+aJ4i/Ha3VPaK7w8kADd6oXxGcNiDI/MJxUTJtsRHCJlzHrFoDN o2/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790889661; x=1791494461; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dIr4K7N8tWlFElP154T0gDhZmtv6PLeTBLURDyjAzjU=; b=e9zhfJVyinUembukzM9kwTa2BG4yuaxkGZJt7s9gfib4NFYbywhQGchPKQfwReRRJ2 Ym0HBab5OymsG2kkdf8N0zyRPyg7x816TOaaxYWRNCC64B5Nzob+jLHFUjCuynLgLc0U FUmODk/tj2ljQbEtJ/ZS4qCu1V59hiPhrugGLYGMmfLb8xufWSxVHu3hlvrkX/5lMJBg 8670GP2I8wnqRlnDlxd2SEusGrA0esVNcekBDetdFZ/9JnhuoAComSHq9AJiLQTUOxhy nNstik75lPk6IqV+tz/yuR/ITzA9MUapcx9N8lZZ//jOb0ZTzxdRCLPm2moz0VGCtL1w wLJA== X-Forwarded-Encrypted: i=1; AKwUvBwR7n0Mi87ITRkNWk/Ne1fgR/ezZkD/YGTHz1XSa/hRjOYHdxrBtLBHXyCajHFH+898s4MP3nwhH7dTlvY=@vger.kernel.org X-Gm-Message-State: AFuF++mUeHzssDgo8xwZ2+bWgCdFg+I9C0Zh/j4XmOxq3uHqymLKKp8D 1xJ2+fYqbx95hTYSuW0sebNdwKzSnQmrx4D4kpG25kcVxAjkVhH4tU/Dhfy9OkyhBKCMJaV+KwA 7VPJO80vv3AKJrsMb8+OLxFuoWg== X-Received: from iobir24.prod.google.com ([2002:a05:6602:7158:b0:9c3:8b15:2c82]) (user=coltonlewis job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:6905:b0:4c3:a091:52f9 with SMTP id 5614622812f47-4f526747d3fmr385353b6e.2.1790889660625; Thu, 01 Oct 2026 14:21:00 -0700 (PDT) Date: Thu, 1 Oct 2026 21:21:00 +0000 In-Reply-To: <56d86280-fcea-4d2d-b6b9-b47449f3408d@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260924172928.2110956-1-coltonlewis@google.com> <20260924172928.2110956-21-coltonlewis@google.com> <56d86280-fcea-4d2d-b6b9-b47449f3408d@linaro.org> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20261001212100.2035442-1-coltonlewis@google.com> Subject: Re: [PATCH v9 20/22] KVM: arm64: Add vCPU device attr to partition the PMU From: Colton Lewis To: James Clark Cc: Colton Lewis , Marc Zyngier , Oliver Upton , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Fuad Tabba , Catalin Marinas , Will Deacon , Mark Rutland , Paolo Bonzini , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Robin Murphy , Zide Chen , Alexandru Elisei , Ganapatrao Kulkarni , Mingwei Zhang , Jonathan Corbet , Russell King , Shuah Khan , linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Hi James, On Wed, Sep 30, 2026 at 04:27:27PM +0100, James Clark wrote: > > @@ -77,7 +80,9 @@ Parameters: in:imaan address of a u32 value (N) > > Returns: > > ======= ==================================================== > > -EBUSY PMUv3 already initialized, or a vCPU has already run > > - -EINVAL No PMUv3 explicitly selected, or value of N out of range > > + -EINVAL No PMUv3 explicitly selected, or value of N out of > > + range (>= max_counters when partitioning is > > + enabled) > > "No PMUv3 explicitly selected, or value of N > max_counters, or N > > max_counters - 1 when partitioning is enabled". > > That might be clearer, otherwise it seems like max_counters being relevant > to "out of range" only applies to when partitioning is enabled, not that > it's max_counters all the time but one is -1. Agreed, that reads much better. I will update it to your phrasing in v10. Thanks, Colton