From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f38.google.com (mail-pj2-f38.google.com [74.125.227.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E902798F8 for ; Thu, 1 Oct 2026 23:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790897124; cv=none; b=FXWgHL8AhwLZVQZ0PflZSee33T6Arxq2sSkvLHAO+/oyRAEDUPiOYPpAofPrboJu5RFC7OmHDcTEykB18dXoyMYc4bR3miljLhlQhbyFQxJP3AfYEr+CQGbICFaO9HecqZt4sB2xnarCwiIqMkODl+xPYzLDiQZuCXT4epADyS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790897124; c=relaxed/simple; bh=4V9v+mjG0zhXxSWO26pcKQ89+JAT4WwWGoWGEwE6vYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RVd9wilo/jZ8hhsVEEtoYTQdccEmtur7qkNCiUNZi5J9z47XGZ06genVzrvAkTu0VhRkX8k8e6AHZEsSyOoZDqVfmTAb8KSmnyntQGmuY0pbK4jdT7Z9iLjXczqrAolY+zOnXdmVnEL/sTQ31wr+nRHZnVqaYyjlZmcdZeNWq8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UPUpa+l5; arc=none smtp.client-ip=74.125.227.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UPUpa+l5" Received: by mail-pj2-f38.google.com with SMTP id 98e67ed59e1d1-3a4bd597d68so1575486a91.2 for ; Thu, 01 Oct 2026 16:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790897122; x=1791501922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4V9v+mjG0zhXxSWO26pcKQ89+JAT4WwWGoWGEwE6vYw=; b=UPUpa+l5VNAAqFFK1x7+Ompf0QrdtM1LnN1styLYSPvFPuJrmcSMVM39buyGCrM2hA ZQEtXF6TOFQWrIb+x6syj22dhuPPjT/x7eW4XyLEuP0KKstQv5RUtiu0k9IfnkVspjJ2 dvd5rG+uA1WZsdCaL7RjGbcR+F25DwDRRz2qy1qahOPwF4JoD6EgN5ysqQMRgWKbb3ae yk8hoD31VbzdVTWpFS91pAKVbEYFLqOrnAL9kCKTFE613EM1xd00O1GXSzoblZa7vy8z pxFeB4TSYtzyaeNb1rOuV2k0VRrUJ5+ATdojsCQ1uPlowOmNq3iBOGhS7L4WUkl3qi41 4r4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790897122; x=1791501922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4V9v+mjG0zhXxSWO26pcKQ89+JAT4WwWGoWGEwE6vYw=; b=C64VKyl34h6EY0W5FNI3fGQJ1GdGYrYwOAg5a99cAyZnag/V2hqL340zj3PFb7RbmB qqm8bGD00BCcjqZR67YSj+7RuwC1xbQIxkuiYH3OEFTcgLWw/9JxTOkxXB4zoXttAkVt 3Z11Ey7yVv4rB/SI8qC/OofyoZeTRVrDyQHRAEtsy6uvLS6IoycKV43t//i1LQSrDzII 1qy7HJepTSGRz1gI5lUSv0a/exPTSOIoNvqz2OG7iT+EpwLT0RIJSNWHmh0QN/I9+HVG FCgWXPtlEguUwEwkRpt/2c0GPoDnBTPy/sBsx65AunPrWaSoqWDNinqBqSBWyatE+8ZS V/EA== X-Forwarded-Encrypted: i=1; AKwUvBwWuimR1DwljWHT52v8Yba2/pQ8Vj7y/Nj46CB35aTtsHRGIwdrAFky1JDwnsgvofknVkycuqbeTAMyfpA=@vger.kernel.org X-Gm-Message-State: AFq9FYLVOXXmPFWAZqAS6e46AqHclXNctJ71nFN+Sdd/8CKbDF1DfjXt mFwWd0nBBaRO0pivBjiNwwnnOHlwyPbuyAWU47CjV2oIMloh9k0HFKEX X-Gm-Gg: AYBFou3WmxFWLsquobTRhziFjnUAMbsR/dkAGz6IIsmTysFcxQW8d8N5iT7TzbAFvtB ovIZ5IN4vlUS7ggUW44TZ96g985iC8jJ9eLUQho474nf7NL90Az2xmYGgfgCTo3yXbK4cnucXHt UCSGsqdAcJSRmuZCUANMhw8PSsBR8vC4ovqBbyiTNN3MzrlsHm+1QUBP5i3XjXYW93HnqXZfDeb 10vnYAtZxapMvcPRH8ZYdnNEu9nLW2t7Uhiy0fmKiZugTKUO8wFClIp9fsXEPq/7XdTxx0wHQBb borKiXBAJcjv7HVud0U/+eq8BseurjeC945m/3vsj+y7q61u1IcHkBuKR2qy8P7LWZz8q57PE/M W1R9V+nCafkiLMQtMvPCg1Gg09ijukLTDAFbjQhyrUfdzE36TLOeH0s+OR7IF7qnjZiLkoTwE4o SnxaSIMtTqHp6ranvATgHceY3+6C+s6i7ucmLdKCwkPcgla9JlkiW6pyPsumjp4niaB4F+Ow== X-Received: by 2002:a17:90a:da8b:b0:3a0:79e6:b45d with SMTP id 98e67ed59e1d1-3a6ceb1393dmr859415a91.54.1790897122430; Thu, 01 Oct 2026 16:25:22 -0700 (PDT) Received: from kdev.. ([108.180.130.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a6dd5f0baasm271958a91.2.2026.10.01.16.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 16:25:21 -0700 (PDT) From: Babanpreet Singh To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Vinod Koul , Bjorn Andersson , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bbnpreetsingh@gmail.com Subject: Re: [PATCH] slimbus: qcom-ngd-ctrl: Release the TX descriptor on error paths Date: Thu, 1 Oct 2026 23:25:20 +0000 Message-ID: <20261001232520.7-1-bbnpreetsingh@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <6c1c602f-2b6d-40f6-8cd4-617239554b15@kernel.org> References: <20260820035203.7-1-bbnpreetsingh@gmail.com> <6c1c602f-2b6d-40f6-8cd4-617239554b15@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Srinivas, Static analysis, then reading. smatch flagged the txn->msg check in qcom_slim_ngd_xfer_msg() and while I was looking at that function I noticed the two returns between tx_msg_get() and tx_msg_post(). I do not have a SLIMbus target. The -ENOMEM consequence in the commit message is derived from the code rather than observed: tx_head only moves in qcom_slim_ngd_tx_msg_dma_cb() and in the re-init path, so a descriptor that is claimed and never posted has no way back into the ring. Verification was build only. On the stable tag: I can send a v2 with Cc: stable and the "found by static analysis, compile tested only" wording. Thanks, Babanpreet