From: Greg KH <gregkh@linuxfoundation.org>
To: Omer PALA <palaomer100@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: remove unnecessary parentheses
Date: Thu, 1 Oct 2026 07:48:22 +0200 [thread overview]
Message-ID: <2026100127-fifty-wrought-2d30@gregkh> (raw)
In-Reply-To: <20260916090145.34881-1-palaomer100@gmail.com>
On Wed, Sep 16, 2026 at 12:01:45PM +0300, Omer PALA wrote:
> Remove unnecessary parentheses around equality checks in sm750_accel.c
>
> and ddk750_swi2c.c to clear checkpatch.pl checks and improve code
>
> readability.
Why the extra blank lines in the changelog text?
And no, this doesn't increase readability, now you need to go and
remember the operator precidence ordering, right? checkpatch shouldn't
be warning of this option in these files, are you sure you are using the
latest tree?
thanks,
greg k-h
next prev parent reply other threads:[~2026-10-01 5:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 9:01 Omer PALA
2026-10-01 5:48 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-20 16:44 [PATCH] staging: sm750fb: Remove " Cheolu Choi
2024-11-20 18:46 ` Greg KH
2023-10-16 13:00 [PATCH] staging: sm750fb: remove " Nandha Kumar Singaram
2023-10-16 14:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026100127-fifty-wrought-2d30@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=palaomer100@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®