Re: [PATCH v2] staging: rtl8723bs: rename phy_status_rpt_8192cd_t to rtl8723bs_phy_status_rpt.

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Oct 01, 2026 at 05:18:14PM +0200, Timo Joannin wrote:
> The struct identifier references the 8192CD chip while being in a
> rtl8723bs codebase. Additionally, the identifier uses the _t suffix,
> while being generally reserved for typedef identifiers.
> 
> Rename the struct to rtl8723bs_phy_status_rpt
> across the rtl8723bs codebase to accurately
> reflect the driver and clean up the naming.
> 
> Additionally, propagate the real structure type all the way
> through the call chain to remove redundant casts to and from u8 *.
> 
> Signed-off-by: Timo Joannin <timo.joannin@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.c   | 6 +++---
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.h   | 5 +++--
>  drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 7 ++++---
>  3 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> index 34b0369a7936..c85194c8fe67 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> @@ -95,7 +95,7 @@ static s8 odm_cck_rssi(u8 lna_idx, u8 vga_idx)
>  
>  static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
>  				      struct odm_phy_info *phy_info,
> -				      u8 *phy_status,
> +				      struct rtl8723bs_phy_status_rpt *phy_sta_rpt,
>  				      struct odm_packet_info *pkt_info)
>  {
>  	u8 i;
> @@ -105,7 +105,6 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
>  	bool is_cck_rate = false;
>  	u8 rf_rx_num = 0;
>  	u8 lna_idx, vga_idx;
> -	struct phy_status_rpt_8192cd_t *phy_sta_rpt = (struct phy_status_rpt_8192cd_t *)phy_status;
>  
>  	is_cck_rate = pkt_info->data_rate <= DESC_RATE11M;
>  	phy_info->rx_mimo_signal_quality[RF_PATH_A] = -1;
> @@ -383,7 +382,8 @@ static void odm_Process_RSSIForDM(
>  
>  /*  Endianness before calling this API */
>  void odm_phy_status_query(struct dm_odm_t *dm_odm, struct odm_phy_info *phy_info,
> -			  u8 *phy_status, struct odm_packet_info *pkt_info)
> +			  struct rtl8723bs_phy_status_rpt *phy_status,
> +			  struct odm_packet_info *pkt_info)
>  {
>  
>  	odm_rx_phy_status_parsing(dm_odm, phy_info, phy_status, pkt_info);
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.h b/drivers/staging/rtl8723bs/hal/odm_HWConfig.h
> index ca3380328a72..21182a880da3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.h
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.h
> @@ -18,7 +18,7 @@ struct phy_rx_agc_info_t {
>  	#endif
>  };
>  
> -struct phy_status_rpt_8192cd_t {
> +struct rtl8723bs_phy_status_rpt {
>  	struct phy_rx_agc_info_t path_agc[2];
>  	u8 ch_corr[2];
>  	u8 cck_sig_qual_ofdm_pwdb_all;
> @@ -57,7 +57,8 @@ struct phy_status_rpt_8192cd_t {
>  };
>  
>  void odm_phy_status_query(struct dm_odm_t *dm_odm, struct odm_phy_info *phy_info,
> -			  u8 *phy_status, struct odm_packet_info *pkt_info);
> +			  struct rtl8723bs_phy_status_rpt *phy_status,
> +			  struct odm_packet_info *pkt_info);
>  
>  enum hal_status ODM_ConfigRFWithTxPwrTrackHeaderFile(struct dm_odm_t *pDM_Odm);
>  
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> index 304fda3a3b5c..a62b845c69f9 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> @@ -73,7 +73,7 @@ static void update_recvframe_attrib(struct adapter *padapter,
>   *precvframe->u.hdr.rx_data should be ready!
>   */
>  static void update_recvframe_phyinfo(union recv_frame *precvframe,
> -				     struct phy_stat *pphy_status)
> +				     struct rtl8723bs_phy_status_rpt *pphy_status)
>  {
>  	struct adapter *padapter = precvframe->u.hdr.adapter;
>  	struct rx_pkt_attrib *pattrib = &precvframe->u.hdr.attrib;
> @@ -125,7 +125,7 @@ static void update_recvframe_phyinfo(union recv_frame *precvframe,
>  	pkt_info.data_rate = pattrib->data_rate;
>  
>  	odm_phy_status_query(&p_hal_data->odmpriv, p_phy_info,
> -			   (u8 *)pphy_status, &(pkt_info));
> +			   pphy_status, &(pkt_info));
>  	if (psta)
>  		psta->rssi = pattrib->phy_info.RecvSignalPower;
>  	precvframe->u.hdr.psta = NULL;
> @@ -317,7 +317,8 @@ static void rtl8723bs_recv_tasklet(struct tasklet_struct *t)
>  
>  				if (pattrib->pkt_rpt_type == NORMAL_RX) { /* Normal rx packet */
>  					if (pattrib->physt)
> -						update_recvframe_phyinfo(precvframe, (struct phy_stat *)ptr);
> +						update_recvframe_phyinfo(precvframe,
> +							(struct rtl8723bs_phy_status_rpt *)ptr);
>  
>  					rtw_recv_entry(precvframe);
>  				} else if (pattrib->pkt_rpt_type == C2H_PACKET) {
> -- 
> 2.55.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot