mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool
Date: Thu, 1 Oct 2026 13:15:52 +0200	[thread overview]
Message-ID: <2026100140-osmosis-easel-30bd@gregkh> (raw)
In-Reply-To: <CAGEkeHd__+Vc9cUuYwUWcnjtBEGU-Lt58TpEnHf_dQGQpUErdw@mail.gmail.com>

On Thu, Oct 01, 2026 at 02:42:47AM -0700, Hungyu Lin wrote:
> > Please change the variable that is assigned to the output of this
> > function as well.
> 
> I changed queue_empty, which receives the return value of
> rtl8723_dequeue_writeport(), from u8 to bool later in the patch:
> 
> > -       u8 queue_empty, queue_pending;
> > +       bool queue_empty;
> > +       u8 queue_pending;
> 
> Were you referring to a different variable?

Ah, missed that, can you please resend?

thanks.

greg k-h

      reply	other threads:[~2026-10-01 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26 10:58 Hungyu Lin
2026-10-01  9:28 ` Greg Kroah-Hartman
2026-10-01  9:42   ` Hungyu Lin
2026-10-01 11:15     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100140-osmosis-easel-30bd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dennylin0707@gmail.com \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®