From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: nenkov2004@gmail.com, rust-for-linux@vger.kernel.org,
Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: binder: Use lower bound for node debug lookup
Date: Thu, 1 Oct 2026 15:54:00 +0200 [thread overview]
Message-ID: <2026100149-sampling-playtime-f5e6@gregkh> (raw)
In-Reply-To: <CAH5fLgh5MRMRJfym-Cv=P_bqCzZ+jXh=ieTD=hPX4KrktKtBiA@mail.gmail.com>
On Thu, Oct 01, 2026 at 03:43:25PM +0200, Alice Ryhl wrote:
> On Thu, Oct 1, 2026 at 2:38 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Aug 31, 2026 at 07:49:20AM +0200, nenkov2004@gmail.com wrote:
> > > From: Hristos Nenkov <nenkov2004@gmail.com>
> > >
> > > The Binder node debug lookup currently walks the process node RBTree
> > > from the beginning until it finds the first node pointer greater than
> > > the requested pointer.
> > >
> > > Use RBTree::cursor_lower_bound() to start the lookup at the relevant
> > > tree position instead. When the lower-bound key is equal to the
> > > requested pointer, inspect the next node to preserve the existing
> > > strictly-greater-than semantics.
> > >
> > > This changes the tree lookup from a linear scan to an O(log n) search
> > > without changing the returned node semantics.
> > >
> > > Suggested-by: Alice Ryhl <aliceryhl@google.com>
> > > Link: https://github.com/Rust-for-Linux/linux/issues/1249
> > > Signed-off-by: Hristos Nenkov <nenkov2004@gmail.com>
> > > ---
> > > drivers/android/binder/process.rs | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > This does not apply to the char-misc-testing branch :(
>
> Please check this instead:
> https://lore.kernel.org/all/20260814215145.2050599-1-rafael@rcpassos.me/
>
> This one is a duplicate, and I prefer the other one.
Ah good, I already took that one :)
thanks,
greg k-h
next prev parent reply other threads:[~2026-10-01 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 5:26 [PATCH] " nenkov2004
2026-08-31 5:39 ` Greg Kroah-Hartman
2026-08-31 5:49 ` [PATCH v2] " nenkov2004
2026-10-01 12:38 ` Greg Kroah-Hartman
2026-10-01 13:43 ` Alice Ryhl
2026-10-01 13:54 ` Greg Kroah-Hartman [this message]
2026-08-31 12:30 ` [PATCH] " Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026100149-sampling-playtime-f5e6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aliceryhl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nenkov2004@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®