From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ashutosh Yadav <yadavxashutosh@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add missing newlines in sysfs_emit formats
Date: Thu, 1 Oct 2026 11:19:13 +0200 [thread overview]
Message-ID: <2026100159-hacked-encourage-fe18@gregkh> (raw)
In-Reply-To: <20260925205328.59183-1-yadavxashutosh@gmail.com>
On Sat, Sep 26, 2026 at 02:23:28AM +0530, Ashutosh Yadav wrote:
> According to Documentation/filesystems/sysfs.rst, sysfs attribute show
> functions should output a single value and terminate with a newline.
>
> Currently, gb_audio_module_name_show(), gb_audio_module_vid_show(),
> gb_audio_module_pid_show(), gb_audio_module_intf_id_show(),
> gb_audio_module_ip_devices_show(), and gb_audio_module_op_devices_show()
> call sysfs_emit() without a trailing newline in their format strings.
>
> Add the missing newline character to each sysfs_emit() format string to
> comply with the sysfs documentation and silence checkpatch warnings.
>
> Signed-off-by: Ashutosh Yadav <yadavxashutosh@gmail.com>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Please read the archives for why this patch keeps getting rejected :)
thanks,
greg k-h
prev parent reply other threads:[~2026-10-01 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 20:53 Ashutosh Yadav
2026-10-01 9:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026100159-hacked-encourage-fe18@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
--cc=yadavxashutosh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®