From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E7A531E106; Fri, 2 Oct 2026 16:44:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790959499; cv=none; b=qMaqOW5VUMsj/K84qHVtxQkYfPC4lXWSvVlYMtaSYeA6jN1Iq7x++ZNEOSt9/aiJ0Ipg2Rznloh6SEU6iUmJAyxB7/OflJ07jWMbQ9FLHJH0/eOnvjY7n8cxO776wqW5/VOHpg9uAH2QbgLPLAQ3kf8NqmV6vrG7W8kbWe4FwWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790959499; c=relaxed/simple; bh=PvjPY2tE3LMCKRCe0VpyM9hEhDXk1IhlIsWX7a2tAOc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=EaAtpRZjPoLrQK8JrqUjlOcuiDX1OyQRhkSL7aP5vm/8K72LsxOz2Ryhxeb8szyRIBTetetSvk6OOY45q8q1G/RUXODxP3qvIcXYwxWVesLv7Dy7mRouqZW+Mvl17W8UG9JYmFWW5OYLGCu+7Q7HS9GPKv2zd0i/1rSVu7EP5ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EgsB2AvC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EgsB2AvC" Received: by smtp.kernel.org (Postfix) with ESMTPS id B4EFEC4AF0B; Fri, 2 Oct 2026 16:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790959498; bh=PvjPY2tE3LMCKRCe0VpyM9hEhDXk1IhlIsWX7a2tAOc=; h=From:Date:Subject:To:Cc:Reply-To:From; b=EgsB2AvCXJeXaTHcSoxMF+EBSnyYglXEvITRez1aQ7jBv3VllTYyUgD5wJvz27Nkd lw8Ai9GRdk2FVDlsVyFXzjWuSpfSQLMVhj8zIYtpvRa1diXogX5fjvx4v/M3zwHccM ZnA8+3ri0sLxkAQXW/Unwy3uqOjf/esy+cYjMK7UUtl61oHVnhvF7rOC3YXRxpDVPu OT7hS14+9S2Kp22jdCCQ+fOSuSbOQHkSpqWz9lDFSHtsbNjoymGS3CNRskYTJB2nhj cZcO13SLnp2NmIkMARtC7YK9YH7yiKfSOk588q7Pf3YlCJwpKT8uadf7CxIcLFcLRa CPhWJzie4nc3g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F992CA5FD4; Fri, 2 Oct 2026 16:44:58 +0000 (UTC) From: Carlos Casadiego via B4 Relay Date: Fri, 02 Oct 2026 11:44:50 -0500 Subject: [PATCH v2] iio: temperature: ltc2983: pass leak detector type explicitly Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261002-iio-ltc2983-fix-string-compare-v2-1-b0a5ba847790@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/42OQQ6CMBBFr0Jm7RhaSbWuvIdhgZ0CY4CSthIN6 d0teAGXL//l/79CsJ5tgGuxgrcLB3ZTBnkowPTN1FlkygyylKrUUiOzwyEaqS8nbPmNIXqeOjR unBtv0WihZVW1pdAEuWT2Nlv7wL3+cXg9ntbErXUzeg7R+c/+YBGb9/fYIlAgqTMpIUkR0a0bG x6OOYc6pfQFIaEJKd4AAAA= X-Change-ID: 20260929-iio-ltc2983-fix-string-compare-c919244f019d To: =?utf-8?q?Nuno_S=C3=A1?= , Jonathan Cameron , David Lechner , Andy Shevchenko , Liviu Stan Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Carlos Casadiego X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790959498; l=5099; i=cdcp206@gmail.com; s=20260921; h=from:subject:message-id; bh=K5qv3NJffI5Efos2hZ/Q+vPtuV6gqDi8mJgL6HUEpEo=; b=daUXcj6Gz0VWXbfgnPvN0sOa1XmPau/xaD2OnRPJYSWDB7yi0VLXtPLZ7eVvHDNZrM7QnhVnx XkXy6OuNBS5CYSAXta0li8Pg0AUlAWILEbM5a9HTpbBHGHmGLc6Kp9B X-Developer-Key: i=cdcp206@gmail.com; a=ed25519; pk=Vr3c2AUi1oYbgVkQtRSsWin33frZn0vGGq5g04VWmH8= X-Endpoint-Received: by B4 Relay for cdcp206@gmail.com/20260921 with auth_id=1041 X-Original-From: Carlos Casadiego Reply-To: cdcp206@gmail.com From: Carlos Casadiego __ltc2983_custom_sensor_new() uses propname both to select the firmware property to read and to determine whether the custom sensor is a leak detector. Pass this information explicitly from the caller instead of deriving the sensor type from the firmware property name. This keeps propname limited to identifying the property and preserves the existing conversion behavior. As a side effect, this also avoids the -Wstring-compare warning reported by the kernel test robot for callers where GCC can determine that the property name cannot match "adi,custom-leak-detector". Fixes: 3dd0c048409e ("iio: temperature: ltc2983: Add support for ADT7604") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202609120045.OxEsKLIn-lkp@intel.com/ Signed-off-by: Carlos Casadiego --- Changes in v2: - Reframe the change around passing the leak detector type explicitly, with the compiler warning as a side effect. - Drop const qualifiers from bool parameters as suggested by Andy Shevchenko. - Link to v1: https://patch.msgid.link/20260929-iio-ltc2983-fix-string-compare-v1-1-d67d612d6ddd@gmail.com To: Nuno Sá To: Jonathan Cameron To: David Lechner To: Andy Shevchenko To: Liviu Stan Cc: linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/iio/temperature/ltc2983.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c index 6efb5252a773..6abaf64c8498 100644 --- a/drivers/iio/temperature/ltc2983.c +++ b/drivers/iio/temperature/ltc2983.c @@ -471,8 +471,9 @@ static int __ltc2983_chan_custom_sensor_assign(struct ltc2983_data *st, static struct ltc2983_custom_sensor * __ltc2983_custom_sensor_new(struct ltc2983_data *st, const struct fwnode_handle *fn, - const char *propname, const bool is_steinhart, - const u32 resolution, const bool has_signed) + const char *propname, bool is_steinhart, + const u32 resolution, bool has_signed, + bool is_leak_detector) { struct ltc2983_custom_sensor *new_custom; struct device *dev = &st->spi->dev; @@ -545,7 +546,7 @@ __ltc2983_custom_sensor_new(struct ltc2983_data *st, const struct fwnode_handle * to µK so __convert_to_raw() produces the correct hardware * encoding: P + 273.15 K. */ - if ((index % 2) != 0 && !strcmp(propname, "adi,custom-leak-detector")) + if ((index % 2) != 0 && is_leak_detector) temp = temp * 1000000 + 273150000; if ((index % 2) != 0) @@ -836,7 +837,7 @@ ltc2983_thermocouple_new(const struct fwnode_handle *child, struct ltc2983_data thermo->custom = __ltc2983_custom_sensor_new(st, child, propname, false, - 16384, true); + 16384, true, false); if (IS_ERR(thermo->custom)) return ERR_CAST(thermo->custom); } @@ -950,7 +951,8 @@ ltc2983_rtd_new(const struct fwnode_handle *child, struct ltc2983_data *st, if (sensor->type == LTC2983_SENSOR_RTD_CUSTOM) { rtd->custom = __ltc2983_custom_sensor_new(st, child, "adi,custom-rtd", - false, 2048, false); + false, 2048, false, + false); if (IS_ERR(rtd->custom)) return ERR_CAST(rtd->custom); } @@ -1068,7 +1070,7 @@ ltc2983_thermistor_new(const struct fwnode_handle *child, struct ltc2983_data *s thermistor->custom = __ltc2983_custom_sensor_new(st, child, propname, steinhart, - 64, false); + 64, false, false); if (IS_ERR(thermistor->custom)) return ERR_CAST(thermistor->custom); } @@ -1184,7 +1186,7 @@ ltc2983_copper_trace_new(const struct fwnode_handle *child, struct ltc2983_data "adi,custom-copper-trace is required for >1 ohm copper trace\n"); ct->custom = __ltc2983_custom_sensor_new(st, child, "adi,custom-copper-trace", - false, 2048, false); + false, 2048, false, false); if (IS_ERR(ct->custom)) return ERR_CAST(ct->custom); @@ -1275,7 +1277,7 @@ ltc2983_leak_detector_new(const struct fwnode_handle *child, struct ltc2983_data "adi,custom-leak-detector is required for leak detectors\n"); ld->custom = __ltc2983_custom_sensor_new(st, child, "adi,custom-leak-detector", - false, 16, false); + false, 16, false, true); if (IS_ERR(ld->custom)) return ERR_CAST(ld->custom); @@ -1488,7 +1490,7 @@ static struct ltc2983_sensor *ltc2983_temp_new(struct fwnode_handle *child, sensor->chan); temp->custom = __ltc2983_custom_sensor_new(st, child, "adi,custom-temp", - false, 4096, true); + false, 4096, true, false); if (IS_ERR(temp->custom)) return ERR_CAST(temp->custom); --- base-commit: d2f2868d2f487b418f68db2ef5bd7cf41722ee68 change-id: 20260929-iio-ltc2983-fix-string-compare-c919244f019d Best regards, -- Carlos Casadiego