mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Beleswar Padhi <b-padhi@ti.com>
Cc: nm@ti.com, kristo@kernel.org, ssantosh@kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, afd@ti.com, u-kumar1@ti.com,
	 vigneshr@ti.com, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: arm: keystone: ti,sci: Update nodename pattern
Date: Fri, 2 Oct 2026 08:27:53 +0200	[thread overview]
Message-ID: <20261002-rugged-nondescript-cheetah-8caa9b@quoll> (raw)
In-Reply-To: <20260930194131.117129-2-b-padhi@ti.com>

On Thu, Oct 01, 2026 at 01:11:26AM +0530, Beleswar Padhi wrote:
> The $nodename pattern for TI-SCI controllers mandates specifying a unit
> address, which in turn requires a 'reg' property. This 'reg' is only
> used to describe an optional memory-mapped debug-messages region.
> 
> Some controllers may not implement this debug region, so it has no 'reg'

Which ones?

> and unit address. Therefore, relax the $nodename pattern to allow the
> unit address to be omitted for such controllers. Keep the unit address
> mandatory for the existing ti,k2g-sci and ti,am654-sci controllers.
> 
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
> Note: This patch is independent can be applied directly.
> 
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
>  .../devicetree/bindings/arm/keystone/ti,sci.yaml  | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e54..67acce8a559a1 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -30,7 +30,7 @@ description: |
>  
>  properties:
>    $nodename:
> -    pattern: "^system-controller@[0-9a-f]+$"
> +    pattern: "^system-controller(@[0-9a-f]+)?$"
>  
>    compatible:
>      oneOf:
> @@ -84,6 +84,19 @@ required:
>    - mbox-names
>    - mboxes
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,k2g-sci
> +              - ti,am654-sci
> +    then:
> +      properties:
> +        $nodename:
> +          pattern: "^system-controller@[0-9a-f]+$"

Drop, not worth complexity.

Best regards,
Krzysztof


  reply	other threads:[~2026-10-02  6:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 19:41 [PATCH 0/6] Enhance TI-SCI FFI with ABI5.0 support Beleswar Padhi
2026-09-30 19:41 ` [PATCH 1/6] dt-bindings: arm: keystone: ti,sci: Update nodename pattern Beleswar Padhi
2026-10-02  6:27   ` Krzysztof Kozlowski [this message]
2026-10-02  9:56     ` Padhi, Beleswar
2026-10-02 10:00       ` Krzysztof Kozlowski
2026-09-30 19:41 ` [PATCH 2/6] dt-bindings: arm: keystone: ti,sci: Add ti,tda54-sci-pdm compatible Beleswar Padhi
2026-10-02  6:31   ` Krzysztof Kozlowski
2026-10-02  9:30     ` Padhi, Beleswar
2026-10-02  9:39       ` Krzysztof Kozlowski
2026-10-02 10:30         ` Padhi, Beleswar
2026-09-30 19:41 ` [PATCH 3/6] firmware: ti: ti_sci_core: Add ABI5.0 Enhancements and TDA54 PDM SCI support Beleswar Padhi
2026-09-30 19:41 ` [PATCH 4/6] firmware: ti: ti_sci_device: Add ABI5.0 compliant Device and Reset APIs Beleswar Padhi
2026-09-30 19:41 ` [PATCH 5/6] firmware: ti: ti_sci_clock: Add ABI5.0 compliant Clock APIs Beleswar Padhi
2026-09-30 19:41 ` [PATCH 6/6] firmware: ti: ti_sci_rm: Add ABI5.0 compliant basic RM APIs Beleswar Padhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002-rugged-nondescript-cheetah-8caa9b@quoll \
    --to=krzk@kernel.org \
    --cc=afd@ti.com \
    --cc=b-padhi@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®