From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD8A83E9F9D for ; Fri, 2 Oct 2026 19:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790967833; cv=none; b=mQYXYen8MiRlfcdqHIdfWhw829S7iazP6HLQB16jbHhe2ZpOvNTsMxUoqTt1uDoTSEWiiJqDfqhqWpcCNFQ0DIYYxsqryDjwctFQ2C0rIFRyr28Tg/8orOLWjRdketz3d8yCRXywDL5E/6hoXIGOcmMAZsTTX+dV+usxmtvNZSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790967833; c=relaxed/simple; bh=TiWi/q8xGcjEmeDCS5JuOhiRjHoHgT0etgyhg2oNuXc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NpO7tcE9dxh2zUZyjk5p/MKaWIG7/o6iW2aaKHAffIhglUnBa9Eq4vvFuSkU8YJAkzF6o1IzFw29ZcE2LJcn9yGv2IBHrfyZPnxDd5/PFSjSGfcFZtEgMLYEy+YEQGtTidusYNKHfpk8oXkT2h0RYKQQpDjLg2Xn8RLEjj6QZtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=DK9sVj88; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="DK9sVj88" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7EEE1476; Fri, 2 Oct 2026 12:03:47 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1343F3F85F; Fri, 2 Oct 2026 12:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790967831; bh=TiWi/q8xGcjEmeDCS5JuOhiRjHoHgT0etgyhg2oNuXc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DK9sVj88zXM5metsERRy3cD/ejQPsB9TTDuYwSmOJ1xUZ3Ba6NOIyjFlffUJpTCaL Udorf8K5ydYxS6hEHxnQQsmbusbW1icTc4m3aSA1LiJzWazSUKGqF2b/e6bMZUU3wg xeyMj7UNJK7de4JfS6pGXJ3kIKoND9zUYAWmgad8= From: Yeoreum Yun Date: Fri, 02 Oct 2026 20:03:27 +0100 Subject: [PATCH v13 06/14] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261002-separate_etm_cfg_v2-v13-6-fe429d8d96fb@arm.com> References: <20261002-separate_etm_cfg_v2-v13-0-fe429d8d96fb@arm.com> In-Reply-To: <20261002-separate_etm_cfg_v2-v13-0-fe429d8d96fb@arm.com> To: Mike Leach , James Clark , Leo Yan , Greg Kroah-Hartman , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: Suzuki K Poulose , Alexander Shishkin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Yeoreum Yun X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=yeoreum.yun@arm.com; h=from:subject:message-id; bh=TiWi/q8xGcjEmeDCS5JuOhiRjHoHgT0etgyhg2oNuXc=; b=owEB7QES/pANAwAKAW3Vw9FaxTEzAcsmYgBqwAAClj6/WMDI/0X3K7yiGCcw9edPlTETeoZQs zMbjgc9L2OJAbMEAAEKAB0WIQQtg+CS3QUzuFh1pJ1t1cPRWsUxMwUCasAAAgAKCRBt1cPRWsUx M66SDADV22CluO+UuRpGCaaHd7GfOWPziCfhgbvB7vkQMVXfIqvxkQT2FIoXatl7Z6rJ5Blh73P FruijSwmWg7HZQMaipt9lWbwbjjf+GbTwT4++DEVHKp7nzD7j4GHPwd1pWtLijXMpd3CdgtCxna ji0MiWZp54bEbeesdgtDUALgXkTrAAGunH0nO/seML2V3UMEuKnNfUsWZ/vQBqJ0E3aPF++soT9 7tqQEAWAsThqQqfWJAyX+K8W7McQjJIounlJX/GLsOmGj/i/2ey1E1lmp/sax0cTzdpYz8kJtR4 kAULPJo+Hs6D7Y8exohZ1g04nK6gSJwf40ExnHov1fEf4bj7i8K4JzyiCBA5OtgzNS40+P5erOC 5IzIglD7ZRgylbI2i6Fm3cnHGGOMAP0dgV8Lv5p9hHKDYUtEgMSW8PpLIw9Pb2Vu2uDjI6axiyh v2tFsESV0uWmPIx9SVc135ehVeRppjKi6uoEhBXDMX+zXM/tlkrWFdL6GxWGtVYhw7esw= X-Developer-Key: i=yeoreum.yun@arm.com; a=openpgp; fpr=2D83E092DD0533B85875A49D6DD5C3D15AC53133 cpu online() check is done in coresight_validate_source_sysfs() already. and smp_call_function_single() will fail when cpu is offline. Therefore, remove redundant check in etm_enable_sysfs(). Reviewed-by: Mike Leach Tested-by: Leo Yan Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm3x-core.c | 26 +++++++++------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index dcadcc383012..ac7c154720cb 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -513,25 +513,19 @@ static int etm_enable_sysfs(struct coresight_device *csdev, struct coresight_pat return -EBUSY; } - /* - * Configure the ETM only if the CPU is online. If it isn't online - * hw configuration will take place on the local CPU during bring up. - */ - if (cpu_online(drvdata->cpu)) { - arg.drvdata = drvdata; - arg.path = path; + arg.drvdata = drvdata; + arg.path = path; - scoped_guard(spinlock, &drvdata->spinlock) { - drvdata->curr_config = drvdata->config; - } + scoped_guard(spinlock, &drvdata->spinlock) { + drvdata->curr_config = drvdata->config; + } - ret = smp_call_function_single(drvdata->cpu, - etm_enable_sysfs_smp_call, &arg, 1); - if (!ret) - ret = arg.rc; - } else { + ret = smp_call_function_single(drvdata->cpu, + etm_enable_sysfs_smp_call, &arg, 1); + if (!ret) + ret = arg.rc; + else ret = -ENODEV; - } if (!ret) { dev_dbg(&csdev->dev, "ETM tracing enabled\n"); -- 2.43.0