mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: scmi: Set the device for the reset controller
Date: Fri, 2 Oct 2026 09:52:37 +0100	[thread overview]
Message-ID: <20261002-statuesque-blond-hog-fe0388@sudeepholla> (raw)
In-Reply-To: <20261002084142.1570378-1-hayashi.kunihiko@socionext.com>

On Fri, Oct 02, 2026 at 05:41:42PM +0900, Kunihiko Hayashi wrote:
> SCMI reset driver does not set rcdev.dev when registering its reset
> controller.
> 
> If rcdev.of_node is not available, the reset core tries to obtain
> the firmware node from rcdev.dev. However, rcdev.dev is also NULL,
> causing a NULL pointer dereference.
> 
> Set rcdev.dev to the SCMI device.
> 

Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>

Worth adding fixes tag IMO

Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI")

Hi Philipp,

Can you please take this in your next round of fixes and/or updates ?

-- 
Regards,
Sudeep

      reply	other threads:[~2026-10-02  8:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  8:41 Kunihiko Hayashi
2026-10-02  8:52 ` Sudeep Holla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002-statuesque-blond-hog-fe0388@sudeepholla \
    --to=sudeep.holla@kernel.org \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®