From: Artem Novak <artem122novak@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Artem Novak <artem122novak@gmail.com>
Subject: [PATCH v2 1/2] sh: guard SH4 no-FPU compiler fallback
Date: Thu, 1 Oct 2026 22:12:19 -0600 [thread overview]
Message-ID: <20261002041220.133911-2-artem122novak@gmail.com> (raw)
In-Reply-To: <20261002041220.133911-1-artem122novak@gmail.com>
The SH4 compiler flag selection falls back to -m4-nofpu when
-mno-implicit-fp is unavailable without checking whether the compiler
supports -m4-nofpu itself.
This breaks SH4A-only toolchains which support -m4a and -m4a-nofpu
but do not provide the plain SH4 -m4-nofpu option.
Use a nested cc-option so the fallback is emitted only when supported.
Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
arch/sh/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index 7b420424b6d7..238c701ab14b 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -36,7 +36,7 @@ cflags-$(CONFIG_CPU_SH2A) += $(call cc-option,-m2a,) \
$(call cc-option,-m4-nofpu,)
cflags-$(CONFIG_CPU_SH3) := $(call cc-option,-m3,)
cflags-$(CONFIG_CPU_SH4) := $(call cc-option,-m4,) \
- $(call cc-option,-mno-implicit-fp,-m4-nofpu)
+ $(call cc-option,-mno-implicit-fp,$(call cc-option,-m4-nofpu,))
cflags-$(CONFIG_CPU_SH4A) += $(call cc-option,-m4a,) \
$(call cc-option,-m4a-nofpu,)
cflags-$(CONFIG_CPU_SH4AL_DSP) += $(call cc-option,-m4al,)
--
2.55.0
next prev parent reply other threads:[~2026-10-02 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 4:12 [PATCH v2 0/2] sh: add initial SH7305 CPU support Artem Novak
2026-10-02 4:12 ` Artem Novak [this message]
2026-10-02 4:12 ` [PATCH v2 2/2] sh: add SH7305 CPU subtype support Artem Novak
2026-11-09 6:43 ` [PATCH v2 0/2] sh: add initial SH7305 CPU support Artem Novak
2026-11-09 7:04 ` John Paul Adrian Glaubitz
2026-11-09 7:11 ` Artem Novak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002041220.133911-2-artem122novak@gmail.com \
--to=artem122novak@gmail.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®