mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Loc Nguyen <loc@ryzome.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH 0/2] KVM: x86: Fix lost nested APF VM-Exits
Date: Fri, 02 Oct 2026 05:41:43 +0000	[thread overview]
Message-ID: <20261002053723.3275202-1-loc@ryzome.com> (raw)

A nested asynchronous page fault delivered to L1 as a synthetic #PF 
VM-Exit can be lost after KVM queues the exception.  Most callers of
kvm_queue_exception_vmexit() arrive through kvm_multiple_exception(),
which requests event processing, but the nested APF path calls the 
helper directly.

Without KVM_REQ_EVENT, vcpu_enter_guest() can skip
kvm_check_and_inject_events() and re-enter L2.  A later VM-Exit can then
clear the pending exception while reconstructing vectoring state.  The 
APF reason remains PAGE_NOT_PRESENT, allowing a later regular #PF to
consume the stale reason.

Patch 1 requests event processing in kvm_queue_exception_vmexit() so
that all queued exception VM-Exits are processed before re-entering the 
guest.

Patch 2 adds a regression test that holds an L2 backing page missing
with userfaultfd.  The test verifies that L1 receives the synthetic #PF 
VM-Exit with the expected APF token and PAGE_NOT_PRESENT reason.

Testing was performed in a nested VMX environment:

  - x86_64 kernel build with KVM_WERROR=y
  - nested_apf_event_test fails on the base kernel with a lost nested
    APF event and passes with the fix 
  - full KVM selftest suite passes
  - kvm-unit-tests VMX suite passes with TIMEOUT=900

Loc Nguyen (2):
  KVM: x86: Request event processing for exception VM-Exits
  KVM: selftests: Add a test for lost nested APF VM-Exits

 arch/x86/kvm/x86.c                            |   2 +
 tools/testing/selftests/kvm/Makefile.kvm      |   1 +
 .../selftests/kvm/x86/nested_apf_event_test.c | 306 ++++++++++++++++++
 3 files changed, 309 insertions(+)
 create mode 100644 tools/testing/selftests/kvm/x86/nested_apf_event_test.c


base-commit: b378201ccd5280d0fff89bbe55e1eb00620ec0d5
-- 
2.43.0



             reply	other threads:[~2026-10-02  5:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  5:41 Loc Nguyen [this message]
2026-10-02  5:42 ` [PATCH 1/2] KVM: x86: Request event processing for exception VM-Exits Loc Nguyen
2026-10-02  5:43 ` [PATCH 2/2] KVM: selftests: Add a test for lost nested APF VM-Exits Loc Nguyen
2026-10-02 21:07 ` [PATCH 0/2] KVM: x86: Fix " Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002053723.3275202-1-loc@ryzome.com \
    --to=loc@ryzome.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®