From: Leo Yan <leo.yan@arm.com>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test: Replace optparse with argparse in attr.py
Date: Fri, 2 Oct 2026 08:52:13 +0100 [thread overview]
Message-ID: <20261002075213.GB1208404@e132581.arm.com> (raw)
In-Reply-To: <CAP-5=fUKDL6yDs0-7h7zz43BJ1uwC6Y-CiS5TMh+=F=iNc=7Jw@mail.gmail.com>
On Thu, Oct 01, 2026 at 09:20:20AM -0700, Ian Rogers wrote:
> On Thu, Oct 1, 2026 at 8:52 AM Leo Yan <leo.yan@arm.com> wrote:
> >
> > Depending on the Python and pylint versions, pylint can report that
> > optparse is deprecated and fail the lint check. Use argparse to avoid
> > this potential warning.
> >
> > Preserve the existing options and defaults, and let argparse handle
> > help and unexpected positional arguments.
> >
> > Tested with:
> >
> > # ./perf test -v 'Perf attribute expectations test'
> > 78: Perf attribute expectations test : Ok
> >
> > Suggested-by: Ian Rogers <irogers@google.com>
> > Signed-off-by: Leo Yan <leo.yan@arm.com>
>
> Hi Leo, thanks for the fix! I see Arnaldo already took this equivalent change:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=tmp.perf-tools-next&id=cd116fcbc0bec7340a659e62210b963c49f93c1e
>
> Sorry for the extra work, but again thanks!
It is fine, thanks let me know.
prev parent reply other threads:[~2026-10-02 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 15:52 Leo Yan
2026-10-01 16:20 ` Ian Rogers
2026-10-02 7:52 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002075213.GB1208404@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®