From: Sergey Lebedev <lsa.uz@pm.me>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andre Gilerson <andre.gilerson@gmail.com>,
Dan Scally <dan.scally@ideasonboard.com>
Cc: Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
German Pablo Lindo <germanpapulindez@gmail.com>,
sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/3] media: i2c: Add Sony IMX681 sensor driver
Date: Fri, 02 Oct 2026 09:53:32 +0000 [thread overview]
Message-ID: <20261002095324.65355-1-lsa.uz@pm.me> (raw)
In-Reply-To: <20261002082537.74084-3-lsa.uz@pm.me>
Sashiko's review of this patch [1] went to devicetree, not linux-media. It
asks whether the flip controls are read here without the control handler
lock:
> When a userspace process calls VIDIOC_SUBDEV_ENUM_MBUS_CODE or
> VIDIOC_SUBDEV_S_FMT with V4L2_SUBDEV_FORMAT_TRY, the V4L2 core locks the
> file handle's TRY state, but not the control handler.
The TRY state's lock is the control handler's lock. The driver sets
sd.state_lock to ctrl_handler.lock before v4l2_subdev_init_finalize(), and
subdev_fh_init() allocates each TRY state with sd->state_lock, so these
ioctls hold the same mutex as S_CTRL. No change needed.
[1] https://lore.kernel.org/all/20261002091451.1476A1F000FF@smtp.kernel.org/
Sergey
next prev parent reply other threads:[~2026-10-02 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 8:25 [PATCH v8 0/3] Add support for the Sony IMX681 camera sensor Sergey Lebedev
2026-10-02 8:25 ` [PATCH v8 1/3] dt-bindings: media: Add Sony IMX681 Sergey Lebedev
2026-10-02 8:26 ` [PATCH v8 2/3] media: i2c: Add Sony IMX681 sensor driver Sergey Lebedev
2026-10-02 9:53 ` Sergey Lebedev [this message]
2026-10-02 8:26 ` [PATCH v8 3/3] media: ipu-bridge: Add Sony IMX681 Sergey Lebedev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002095324.65355-1-lsa.uz@pm.me \
--to=lsa.uz@pm.me \
--cc=andre.gilerson@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=germanpapulindez@gmail.com \
--cc=hansg@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®