mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn@kernel.org>
To: Alexander Duyck <alexanderduyck@fb.com>,
	Jakub Kicinski <kuba@kernel.org>,
	kernel-team@meta.com (reviewer:META ETHERNET DRIVERS),
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Björn Töpel" <bjorn@kernel.org>,
	"Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>,
	"Mina Almasry" <almasrymina@google.com>
Subject: [PATCH net v3 0/2] eth: fbnic: Queue and channel count fixes
Date: Fri,  2 Oct 2026 14:56:13 +0200	[thread overview]
Message-ID: <20261002125617.409447-1-bjorn@kernel.org> (raw)

Two fixes for what fbnic tells the core about its queues.

Patch 1 keeps the channel layout across suspend. Resume rebuilt it
from the queue counts, turning standalone channels into combined ones
or dropping combined queues, even with an unchanged IRQ count.

Patch 2 publishes the real queue counts at probe and on "ethtool -L"
while down, instead of at the next open.

Resume with fewer IRQs than the layout needs now fails instead of
shrinking the layout. That case is left for a separate change.

Changes in v3:
- Split into two patches, one per bug, each blaming the commit that
  introduced it.
- Keep num_napi across suspend instead of a separate num_napi_cfg.
- Drop the -ENOSPC check on resume, so an interface that is down no
  longer fails resume. (Breno, Sashiko)
- Skip ndo_stop when no NAPI vectors are allocated.
- Drop Breno's Reviewed-by, since the resume path changed.

Changes in v2:
- Keep the configured NAPI count and restore it on resume. v1
  recomputed it from the queue counts, which changed dedicated rx and
  tx layouts even when the vector count was unchanged. (Breno,
  Sashiko)
- Fail resume with -ENOSPC when fewer vectors come back than the
  configured layout needs. (Sashiko)
- Fix the comment and commit message that did not match the code.
  (Breno, Sashiko)
- Keep the RSS indirection reset in fbnic_netdev_alloc().
- Drop Breno's Reviewed-by, since the resume path changed.

v2: https://lore.kernel.org/netdev/20260924191817.1843726-1-bjorn@kernel.org/
v1: https://lore.kernel.org/netdev/20260915180859.4157646-1-bjorn@kernel.org/

Björn Töpel (2):
  eth: fbnic: Preserve channels across resume
  eth: fbnic: Publish real queue counts

 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  7 ++++
 .../net/ethernet/meta/fbnic/fbnic_netdev.c    | 36 ++++++++++++++-----
 .../net/ethernet/meta/fbnic/fbnic_netdev.h    |  3 --
 drivers/net/ethernet/meta/fbnic/fbnic_pci.c   |  9 -----
 4 files changed, 34 insertions(+), 21 deletions(-)


base-commit: 71a77ab76e74131a101f4d2d2afb0dcbf81b4e3c
-- 
2.55.0


             reply	other threads:[~2026-10-02 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 12:56 Björn Töpel [this message]
2026-10-02 12:56 ` [PATCH net v3 1/2] eth: fbnic: Preserve channels across resume Björn Töpel
2026-10-02 12:56 ` [PATCH net v3 2/2] eth: fbnic: Publish real queue counts Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002125617.409447-1-bjorn@kernel.org \
    --to=bjorn@kernel.org \
    --cc=alexanderduyck@fb.com \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mike.marciniszyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®