mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Elder <elder@riscstar.com>
To: arnd@arndb.de, gregkh@linuxfoundation.org
Cc: daniel@riscstar.com, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: [PATCH v2] misc: Kconfig: tc9564: fix and simplify dependencies
Date: Fri,  2 Oct 2026 09:07:36 -0500	[thread overview]
Message-ID: <20261002140738.393453-1-elder@riscstar.com> (raw)

The TC9564_PCI config option selects PCI_DYNAMIC_OF_NODES.  But that
depends on OF_IRQ, and TC9564_PCI does not satisfy that dependency.
Simply adding "depends on OF_IRQ" results in a recursive Kconfig
dependency, so we need to satisfy it in a different way.

On the other hand, PCI_DYNAMIC_OF_NODES is a user-visible option and
should not be selected.  So switch to depending on that rather than
selecting it.

PCI_DYNAMIC_OF_NODES already depends on OF_IRQ, so we no longer need
to depend on it directly.  OF_IRQ is only exposed as an option if OF
is enabled, so OF_IRQ enabled implies OF is enabled.

Finally, PCI_DYNAMIC_OF_NODES is only exposed as an option if PCI is
enabled, so we can omit the dependency on PCI.

Therefore, depending on (rather than selecting) PCI_DYNAMIC_OF_NODES
satisfies the dependency on OF_IRQ, as well as on OF and PCI.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202610020124.ieOiopjQ-lkp@intel.com/
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1304b0c47ef81 ("misc: tc9564: introduce base PCI driver")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
 drivers/misc/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 9c5b1e9d672e8..6ae10ef8b3cc4 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -570,9 +570,7 @@ config MCHP_LAN966X_PCI
 
 config TC9564_PCI
 	tristate "Toshiba TC9564 PCI function support"
-	depends on OF
-	depends on PCI
-	select PCI_DYNAMIC_OF_NODES
+	depends on PCI_DYNAMIC_OF_NODES
 	select PCI_QUIRKS
 	default m
 	help

base-commit: 04434a1d0f311d76b1f15fa987918b471a0b8c6a
-- 
2.53.0


             reply	other threads:[~2026-10-02 14:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 14:07 Alex Elder [this message]
2026-10-02 14:35 ` Alex Elder
2026-10-02 14:45   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002140738.393453-1-elder@riscstar.com \
    --to=elder@riscstar.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=daniel@riscstar.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®