mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: "Thomas Gleixner" <tglx@kernel.org>,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andy Lutomirski <luto@kernel.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	David Laight <david.laight.linux@gmail.com>,
	linux-kernel@vger.kernel.org,
	Zhan Xusheng <zhanxusheng@xiaomi.com>
Subject: [PATCH v7 0/5] vdso: Keep the CLOCK_AUX base at full precision
Date: Fri,  2 Oct 2026 23:30:58 +0800	[thread overview]
Message-ID: <20261002153104.1347978-1-zhanxusheng@xiaomi.com> (raw)

v6 still broke the m68k build.  I had read the individual 0-day mails for
the BITS_PER_TYPE failure and stopped there, instead of the
"[tip:timers:vdso] BUILD REGRESSION ca46a07c4b68" summary, which lists
both failures and was out 37 minutes before I posted v6.  Sorry.

The remaining one is patch 1: OPTIMIZER_HIDE_VAR() lives in
linux/compiler.h and vdso/math64.h did not include it.  vdso/math64.h is
reached from linux/math64.h, whose includes are linux/types.h,
linux/math.h, asm/div64.h and vdso/math64.h; none of them guarantees
linux/compiler.h.  x86 happens to get it through
asm/div64.h -> linux/log2.h; m68k's asm/div64.h only pulls in
asm-generic/div64.h and linux/types.h, so the macro is undeclared and
-Werror=implicit-function-declaration kills the build.  Patch 1 now
includes linux/compiler.h.

Changes since v6:

 - Patch 1: include linux/compiler.h, with the robot tags
   (Thomas Weissschuh, kernel test robot)
 - Patch 4: picked up Thomas' Reviewed-by
 - No other change

Reproduced on m68k defconfig by compiling a translation unit that includes
linux/stat.h: two errors at vdso/math64.h without the include, none with
it.  Built every commit in order under the same check, all clean.  x86-64
kernel + lib + vDSO, arm64 vDSO and powerpc vDSO build clean,
tools/perf/check-headers.sh is quiet, and checkpatch --strict reports
0/0/0 on all five.

vdso/math64.h is not tracked by check-headers.sh, so unlike patch 4 this
one needs no tools-side sync.

v6: https://patch.msgid.link/20260930154500.722828-1-zhanxusheng@xiaomi.com

Zhan Xusheng (5):
  vdso/math64: Use OPTIMIZER_HIDE_VAR() in __iter_div_u64_rem()
  vdso/math64: Add and use __iter_div64_u64_rem()
  vdso/vsyscall: Keep the CLOCK_AUX base scaled
  vdso: Move BITS_PER_BYTE and BITS_PER_TYPE() to vdso/bits.h
  vdso/gettimeofday: Assert that the clockid fits into the u32 bitmask

 include/linux/bits.h       |  2 --
 include/vdso/bits.h        |  2 ++
 include/vdso/math64.h      | 33 ++++++++++++++++++++++++++++-----
 kernel/time/vsyscall.c     | 26 ++++++++++----------------
 lib/vdso/gettimeofday.c    |  2 ++
 tools/include/linux/bits.h |  2 --
 tools/include/vdso/bits.h  |  2 ++
 7 files changed, 44 insertions(+), 25 deletions(-)


base-commit: 9b87fdc9af2fbfcdb5c24a64139685ef80f6573f
-- 
2.43.0


             reply	other threads:[~2026-10-02 15:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 15:30 Zhan Xusheng [this message]
2026-10-02 15:30 ` [PATCH v7 1/5] vdso/math64: Use OPTIMIZER_HIDE_VAR() in __iter_div_u64_rem() Zhan Xusheng
2026-10-15 15:37   ` [tip: timers/vdso] " tip-bot2 for Zhan Xusheng
2026-10-02 15:31 ` [PATCH v7 2/5] vdso/math64: Add and use __iter_div64_u64_rem() Zhan Xusheng
2026-10-15 15:37   ` [tip: timers/vdso] " tip-bot2 for Zhan Xusheng
2026-10-02 15:31 ` [PATCH v7 3/5] vdso/vsyscall: Keep the CLOCK_AUX base scaled Zhan Xusheng
2026-10-15 15:37   ` [tip: timers/vdso] " tip-bot2 for Zhan Xusheng
2026-10-02 15:31 ` [PATCH v7 4/5] vdso: Move BITS_PER_BYTE and BITS_PER_TYPE() to vdso/bits.h Zhan Xusheng
2026-10-02 15:31 ` [PATCH v7 5/5] vdso/gettimeofday: Assert that the clockid fits into the u32 bitmask Zhan Xusheng
2026-10-15 13:54   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002153104.1347978-1-zhanxusheng@xiaomi.com \
    --to=zhanxusheng1024@gmail.com \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luto@kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    --cc=yury.norov@gmail.com \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®