From: Leo Yan <leo.yan@arm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Wei Xu <xuwei5@hisilicon.com>,
Michal Simek <michal.simek@amd.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: dts: qcom: apq8064: Drop PCLK from static replicator
Date: Fri, 2 Oct 2026 16:33:28 +0100 [thread overview]
Message-ID: <20261002153328.GE1208404@e132581.arm.com> (raw)
In-Reply-To: <z2bu73w3xcl4ofbp4td3rj7wazzoth5gq35obiqkrfhhfxufcq@hrfvij5jnb55>
On Fri, Oct 02, 2026 at 06:21:36PM +0300, Dmitry Baryshkov wrote:
> On Fri, Oct 02, 2026 at 04:07:24PM +0100, Leo Yan wrote:
> > The APQ8064 static replicator has no registers to program, so it
> > does not need an APB clock. Remove its RPM_QDSS_CLK reference.
> > Other programmable CoreSight devices keep their clock references.
>
> QDSS clock is not actually the APB one, it's required for the coresight
> (or to access some of the regs) if I remember correctly.
If so, it might be atclk for clocking the module rather than the
register interface. Could you confirm this?
The replicator is just a middle component on the data path. I read
that it shares the same clock with other CoreSight components, so it
should still be safe to remove the clock from the replicator node,
as other components on the path will ensure that the clock is enabled.
Thanks,
Leo
next prev parent reply other threads:[~2026-10-02 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 15:07 [PATCH 0/5] arm: coresight: Clean up funnel and replicator clocks Leo Yan
2026-10-02 15:07 ` [PATCH 1/5] dt-bindings: arm: coresight: Limit static replicator to atclk Leo Yan
2026-10-02 15:07 ` [PATCH 2/5] dt-bindings: arm: coresight: Allow atclk for static funnel Leo Yan
2026-10-02 15:07 ` [PATCH 3/5] arm64: dts: hisilicon: Drop PCLK from static CoreSight links Leo Yan
2026-10-02 15:07 ` [PATCH 4/5] ARM: dts: zynq: Use dynamic CoreSight funnel and trim clocks Leo Yan
2026-10-02 15:07 ` [PATCH 5/5] ARM: dts: qcom: apq8064: Drop PCLK from static replicator Leo Yan
2026-10-02 15:21 ` Dmitry Baryshkov
2026-10-02 15:33 ` Leo Yan [this message]
2026-10-02 16:05 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002153328.GE1208404@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=james.clark@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=mike.leach@arm.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®