From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E1B53E92AC for ; Fri, 2 Oct 2026 19:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790968506; cv=none; b=YlfzT8rDuANpJcYBphcoQSXb7cwFiy3dq4/GZ20eWGWR7ycPg1ucsGS7xfl8tngB6kNqYz03P5VJ8angmyNATkNfsonU+Md83Y2lxuHizhxW4HicmvPZy+15L+wPRSm8AbvYwPmBJVK1oab6oW615HjDx8ETqOFURrdlVyy8Rss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790968506; c=relaxed/simple; bh=bcf4TTKr4xiw+q9mkTG25UPtKmJvg1MPHgWdyQGIkG0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XRdMd/ZUVHphWPnz28O5Oi693QmhpHr+ZxxBWdoXr9eX6wZoy2bYX3vPLXKbDU9xhaK6q2jk+H3Tqc12ZpeouRFI+q1H3o0qCO37EasFsH4QqNLx8thge2XX8d7JXpwvKyfxlgi/V5HpacI64D2bjsE4t0HkHsUtGGwbpR9acTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O8X0pt/F; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O8X0pt/F" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b912d822dso1574715e9.2 for ; Fri, 02 Oct 2026 12:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790968503; x=1791573303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y/jEcxkavN6IpLXPNJ5kYWQEIq0m0VhLgxkkief1ksQ=; b=O8X0pt/F0l4o+0r5fHPcvjxu9eBpuFOx12kt+qq/WCqOx8MM7w+3Kr83mipJeZ238X mTQRgPDMWkbIMkVXo9sSxxtKlrq7c6AMnqOM/1Cn2rO+z0sFWQhlkbKxeSmRhbDOyM0f 6Hr/9RDR5hi65vQsRvuqPcd3eLPJBcet0qJrj1Iej8WGoBPjcNUGf/85Qsw+EF6zqDT2 vbkZXs7WLrGctYIrELnkta4tFmPvxZBLvVK1O7K9G1pRCzM2KQ7ugdb0qcM/Xgo4VtTg Q6qGYWmkRNbz0PC4xW3R7IKANKJ0OM9CZ2ZWEnmlmEa7oxv4AzES8l8wcFDmmhyRgSYH TEVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790968503; x=1791573303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=y/jEcxkavN6IpLXPNJ5kYWQEIq0m0VhLgxkkief1ksQ=; b=RstktAiRKXVkAGRotkKnPxy40vGbKg5VIjw8WaK9AGV0zrH59Qi3QJeYVhQJY/fZcF hp+Y56LWm1duBtSKkqYyjGU17SIeBE8nEnQN20Snne5IStQPl3ilaCAv1J181DZuFWg0 uqdPn3Tjrlfq7CubSrA7P0wLu5Mbr8vc//7IJVpV6Ew2Tk/iixSr7/EMqFWw8alK3KMJ KzDBprWdJkr2Rf7yVIrLEIOO8tfZJsBLEgup6pjs0ZqYWdXlJptJvDPfbKq/Jniyv9OM 9OnNlis69/gUkcBqOTI/5SroyfAuYxYIoxUpvxmKGOBuilqyT4aQUGn4kzUxdrIwZHuF yCDA== X-Forwarded-Encrypted: i=1; AKwUvBzGPYf/psXTBrldp2TeDM8/fW+TNJkqPZ/+AKsltdZKiewFg18nJzGjFaOrSkdj7i5ZkvrIEByRaxFHops=@vger.kernel.org X-Gm-Message-State: AFuF++nag3MGeVyVlF2PEpHzXkJP+htXVMGTwPcSP4K025kSqtar5+/c YACk2kpypEjLU3PbhuDTPP8ILiWNok5sPqlDMaYGqT+6A/IEuGnRyo5Z X-Gm-Gg: AYBFou0BUhdUfzXQO/WfRnHw6Uh8VS19d1ko6s7iXqeb4eEsJln7yZGtAYMnOUuDtyU qODvEVB0dPpxz6yQNeiiFnVmKi5LFemBPNSRgcUFmud+5i/JWwR3/9MfEs2JGTVVz7an1t+cTjp JtVBDDWAHnw4O95OHAmxlqBGKnynOjdUe8qiFtHw8d37BUYS/wr7wy46rVt1XMyHn0Oa2s0Qfal 8wQfD0OTmMFXvuTuF/HqjNUTIZbP7zgQyMCRoBCbO4goJXlElXlY5LGvtAh61icrPZQIiZP1HB5 KDTQ/4VyBDEogL7o1K3rNtmV6LQ1I7YKgBS0N96ihVxqDdKwwKbiHzbiDvwOXDg2vK5YAMUtFX/ yHYYSBqOlmtye+DzGwsagftJDQlX1WXXaFeVNY77OMT4FLVPcbiYrvblNBD4kKvpH/NLTcmccmZ ExfSF84MO/nrlgWzEYQie9SKz9qSTY+cIvE7bmfoPrcNt18l6cB/ZhFuju9BttKLkgt5JUuqU2I iL4MtDjedgnxdoLz0a0AX9DKcfw3XM7I7amoYYhyEO2VMjyLk+RKQ== X-Received: by 2002:a05:600c:8b88:b0:49c:cee0:f383 with SMTP id 5b1f17b1804b1-4a02757ebcdmr64585175e9.16.1790968503422; Fri, 02 Oct 2026 12:15:03 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a0e1afbc44sm81151145e9.4.2026.10.02.12.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 12:15:02 -0700 (PDT) From: Muhammad Bilal To: Jorge Lopez , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Muhammad Bilal , stable@vger.kernel.org Subject: [PATCH v4 3/9] platform/x86: hp-bioscfg: return -E2BIG from validate_password_input() Date: Sat, 3 Oct 2026 00:14:28 +0500 Message-ID: <20261002191434.58529-4-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261002191434.58529-1-meatuni001@gmail.com> References: <20261002191434.58529-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit validate_password_input() returns the positive INVALID_BIOS_AUTH on rejection. store_password_instance() skips the store on nonzero ret, but its final "return ret < 0 ? ret : count" treats the positive value as success, so userspace sees count instead of an error. Return -E2BIG for an invalid password length. Tested on HP EliteBook 840 G2 (Fedora 44, Linux 7.2.7): writing 999 bytes to current_password returned 999 before this change. Fixes: 8646a3b5ee3a ("platform/x86: hp-bioscfg: passwdobj-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- Changes in v3: - Return -E2BIG instead of -ERANGE (Andy) Changes in v2: - New patch drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c index a9e178637..3f4c45d9b 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -70,12 +70,13 @@ static int validate_password_input(int instance_id, const char *buf) length--; if (length > MAX_PASSWD_SIZE) - return INVALID_BIOS_AUTH; + return -E2BIG; if (password_data->min_password_length > length || password_data->max_password_length < length) - return INVALID_BIOS_AUTH; - return SUCCESS; + return -E2BIG; + + return 0; } ATTRIBUTE_N_PROPERTY_SHOW(is_enabled, password); -- 2.43.0