mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marinela Tatiana Selseth <marinela.selseth@firmwaredesign.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Rename CamelCase NDIS encryption state enums
Date: Fri, 2 Oct 2026 08:07:12 +0200	[thread overview]
Message-ID: <2026100244-uncrushed-railcar-be19@gregkh> (raw)
In-Reply-To: <20261001194710.144114-1-marinela.selseth@firmwaredesign.org>

On Thu, Oct 01, 2026 at 02:47:10PM -0500, Marinela Tatiana Selseth wrote:
> The identifiers Ndis802_11WEPDisabled and Ndis802_11EncryptionDisabled
> violate the Linux kernel coding style guideline regarding naming
> conventions. Uppercase snake_case is preferred for enum constants.
> 
> Rename both constants to NDIS_802_11_WEP_DISABLED and
> NDIS_802_11_ENCRYPTION_DISABLED across the driver framework to conform
> to standard kernel conventions.

Why just these 2?

And shouldn't these be using the in-kernel NDIS values instead of
redefining them?  They seem to be just using random numbers, as the enum
isn't specified.  Or is this just a state value and doesn't reflect
anything actually sent to the device or network stack?

thanks,

greg k-h

  reply	other threads:[~2026-10-02  6:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 19:47 Marinela Tatiana Selseth
2026-10-02  6:07 ` Greg Kroah-Hartman [this message]
2026-10-03  3:16   ` Marinela Tatiana Selseth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100244-uncrushed-railcar-be19@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marinela.selseth@firmwaredesign.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®