mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiale Yao <yaojiale02@163.com>
To: Keke Li <keke.li@amlogic.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	Daniel Scally <dan.scally@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiale Yao <yaojiale02@163.com>
Subject: [PATCH 1/2] media: c3-mipi-adap: handle runtime resume failure
Date: Sat,  3 Oct 2026 16:11:27 +0800	[thread overview]
Message-ID: <20261003081129.433041-2-yaojiale02@163.com> (raw)
In-Reply-To: <20261003081129.433041-1-yaojiale02@163.com>

c3_mipi_adap_enable_streams() ignores runtime resume failures and
continues programming adapter registers before reporting that streaming
started. If the power domain could not be resumed, those register
accesses are unsafe and the disable path later drops a reference that
was not acquired.

Return the runtime PM error before accessing the adapter.

Fixes: f0d2d8062cc8 ("media: platform: Add C3 MIPI adapter driver")
Signed-off-by: Jiale Yao <yaojiale02@163.com>
---
 drivers/media/platform/amlogic/c3/mipi-adapter/c3-mipi-adap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/amlogic/c3/mipi-adapter/c3-mipi-adap.c b/drivers/media/platform/amlogic/c3/mipi-adapter/c3-mipi-adap.c
index 4bd98fb9c7e9..750b301f4bbf 100644
--- a/drivers/media/platform/amlogic/c3/mipi-adapter/c3-mipi-adap.c
+++ b/drivers/media/platform/amlogic/c3/mipi-adapter/c3-mipi-adap.c
@@ -455,7 +455,9 @@ static int c3_mipi_adap_enable_streams(struct v4l2_subdev *sd,
 
 	src_sd = media_entity_to_v4l2_subdev(adap->src_pad->entity);
 
-	pm_runtime_resume_and_get(adap->dev);
+	ret = pm_runtime_resume_and_get(adap->dev);
+	if (ret < 0)
+		return ret;
 
 	fmt = v4l2_subdev_state_get_format(state, C3_MIPI_ADAP_PAD_SINK);
 
-- 
2.34.1


  reply	other threads:[~2026-10-03  8:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03  8:11 [PATCH 0/2] media: amlogic: handle C3 MIPI runtime resume failures Jiale Yao
2026-10-03  8:11 ` Jiale Yao [this message]
2026-10-19  6:23   ` [PATCH 1/2] media: c3-mipi-adap: handle runtime resume failure Keke Li
2026-10-03  8:11 ` [PATCH 2/2] media: c3-mipi-csi2: " Jiale Yao
2026-10-19  6:24   ` Keke Li
2026-10-19  7:31     ` Jacopo Mondi
2026-10-19  8:48       ` Keke Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261003081129.433041-2-yaojiale02@163.com \
    --to=yaojiale02@163.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=hverkuil@kernel.org \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=keke.li@amlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®