From: Serhat Kumral <serhatkumral1@gmail.com>
To: gregkh@linuxfoundation.org
Cc: hansg@kernel.org, israel.a.cepeda.lopez@intel.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
sakari.ailus@linux.intel.com, serhatkumral1@gmail.com
Subject: Re: [PATCH] usb: misc: usbio: Handle negative error code from usb_control_msg()
Date: Sat, 3 Oct 2026 19:18:24 +0300 [thread overview]
Message-ID: <20261003161824.22338-1-serhatkumral1@gmail.com> (raw)
In-Reply-To: <2026100327-doornail-jaws-c582@gregkh>
On Sat, Oct 03, 2026 at 17:13:45 +0200, Greg KH wrote:
> Ick, really? There's no compiler check for this type of thing?
> This whole function needs to be rewritten to use the "modern" control
> message functions. I gave it a go once, but it quickly got messy as
> this is an abused function and it really should be massivly cleaned up.
> Do you have the hardware for this to test changes?
Unfortunately I don't have the hardware. I relied on static analysis
and tried to keep things quite simple
thanks,
Serhat
prev parent reply other threads:[~2026-10-03 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 14:28 Serhat Kumral
2026-10-03 15:13 ` Greg KH
2026-10-03 16:18 ` Serhat Kumral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003161824.22338-1-serhatkumral1@gmail.com \
--to=serhatkumral1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=israel.a.cepeda.lopez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®