From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marinela Tatiana Selseth <marinela.selseth@firmwaredesign.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: condense NDIS encryption status enum
Date: Sat, 3 Oct 2026 10:59:48 +0200 [thread overview]
Message-ID: <2026100334-delegator-status-fa8c@gregkh> (raw)
In-Reply-To: <20261003074943.267819-1-marinela.selseth@firmwaredesign.org>
On Sat, Oct 03, 2026 at 02:49:43AM -0500, Marinela Tatiana Selseth wrote:
> Address maintainer feedback regarding loose anonymous enum constants
> and redundant naming aliases. The legacy driver framework contained
> multiple duplicate definitions (such as mapping both WEPDisabled and
> EncryptionDisabled to identical tracking states) alongside several
> completely unreferenced, dead tracking properties.
>
> Clean up this subsystem by defining an explicit, named enumeration
> layout 'enum ndis_802_11_encryption_status' inside wlan_bssdef.h.
> Consolidate redundant aliases down to singular, uniform variables,
> purge all unused legacy elements (KeyAbsent, NotSupported, and
> EncrypteionWAPI blocks), and convert all remaining active states
> over to standard uppercase snake_case conventions.
>
> Update all internal software state assignments and state evaluation
> loops across the entire driver operational baseline to conform to the
> updated definitions, ensuring code tracking clarity while leaving
> hardware execution behaviors completely unaltered. Fix associated
> line length violations and remove redundant braces for single-statement
> conditions introduced by long macro names.
>
> Signed-off-by: Marinela Tatiana Selseth <marinela.selseth@firmwaredesign.org>
Did you forget an Assisted-by: tag?
And isn't this v2?
thanks,
greg k-h
prev parent reply other threads:[~2026-10-03 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 7:49 Marinela Tatiana Selseth
2026-10-03 8:59 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026100334-delegator-status-fa8c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marinela.selseth@firmwaredesign.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®