mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: lance.yang@linux.dev, mhiramat@kernel.org, pmladek@suse.com,
	linux-kernel@vger.kernel.org, david.laight.linux@gmail.com,
	brads@mainlining.org, neelx@suse.com, sean@ashe.io,
	chjohnst@gmail.com, steve@abita.co, mproche@gmail.com,
	nick.lange@gmail.com
Subject: Re: [PATCH v11 0/2] hung_task: Improve warning budget handling and task reporting
Date: Sun, 4 Oct 2026 11:28:19 -0700	[thread overview]
Message-ID: <20261004112819.6dc90ddd0fb33ef8f2e58531@linux-foundation.org> (raw)
In-Reply-To: <20261004163610.413506-1-atomlin@atomlin.com>

On Sun,  4 Oct 2026 12:36:08 -0400 Aaron Tomlin <atomlin@atomlin.com> wrote:

> The hung_task watchdog detects tasks stuck in TASK_UNINTERRUPTIBLE (D)
> state for longer than CONFIG_DEFAULT_HUNG_TASK_TIMEOUT seconds. To prevent
> log spam during system spikes, sysctl_hung_task_warnings enforces a budget
> on the number of logged warnings.
> 
> However, the current implementation has two major limitations:
> 
> ...
> 
> This patch series resolves both limitations by decoupling the configured
> warning limit from the active runtime budget, automatically resetting the
> budget upon system recovery or sysctl updates, and emitting a single
> aggregate summary line when hung tasks are detected under an exhausted
> warning budget.

Thanks, I've updated mm.git's mm-nonmm-unstable branch to this version.

> 
> Changes since v10:
> 
>  - Guarded the suppression notice in hung_task_info() with
>    !hung_task_call_panic so suppression messages are not emitted for tasks
>    dumped while panicking, and simplified the log message to state details
>    are suppressed until the budget is reset
> 
>  - Added Reviewed-by: tag from Bradley Morgan <brads@mainlining.org>
> 

Here's how v11 altered mm.git:


 kernel/hung_task.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/hung_task.c~b
+++ a/kernel/hung_task.c
@@ -276,8 +276,8 @@ static void hung_task_info(struct task_s
 		sched_show_task(t);
 		debug_show_blocker(t, timeout);
 
-		if (!hung_task_warnings_budget)
-			pr_info("hung_task: further per-task details suppressed until warning budget is reset or panic is triggered (see sysctl kernel.hung_task_warnings)\n");
+		if (!hung_task_warnings_budget && !hung_task_call_panic)
+			pr_info("hung_task: further per-task details suppressed until warning budget is reset (see sysctl kernel.hung_task_warnings)\n");
 	}
 
 	touch_nmi_watchdog();
_


      parent reply	other threads:[~2026-10-04 18:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04 16:36 Aaron Tomlin
2026-10-04 16:36 ` [PATCH v11 1/2] hung_task: Reset warning budget when problem gets resolved Aaron Tomlin
2026-10-04 16:51   ` Bradley Morgan
2026-10-04 16:36 ` [PATCH v11 2/2] hung_task: Log summary line when warning budget is exhausted Aaron Tomlin
2026-10-04 18:28 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261004112819.6dc90ddd0fb33ef8f2e58531@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=brads@mainlining.org \
    --cc=chjohnst@gmail.com \
    --cc=david.laight.linux@gmail.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mproche@gmail.com \
    --cc=neelx@suse.com \
    --cc=nick.lange@gmail.com \
    --cc=pmladek@suse.com \
    --cc=sean@ashe.io \
    --cc=steve@abita.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®