From: Omar Ramadan <omar@blockcast.net>
To: netdev-bot+sashiko@kernel.org
Cc: Taehee Yoo <ap420073@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] amt: mark relay data as a UDP tunnel packet before sending it
Date: Sun, 4 Oct 2026 17:01:23 +0300 [thread overview]
Message-ID: <20261004140123.94341-1-omar@blockcast.net> (raw)
In-Reply-To: <179106416186.434549.2202047416681649119@kernel.org>
On Sat, Oct 3, 2026, Sashiko wrote:
> Should this have a Fixes: tag?
No, on purpose. Eric asked for this to go to net-next, since the bug
needs a non-default setting:
"Note that tx checksum offload is off by default on amt, so the bug
would not trigger by default."
"A better fix would be (for net-next) to call
udp_tunnel_handle_offloads() in amt_send_multicast_data() like other
UDP tunnels do"
https://lore.kernel.org/all/CAL4Wiiqw_7Mxa5W1EQgw2=KpJNNxG=cBLXsHvpio29GvD1UKZg@mail.gmail.com/
> This is a pre-existing issue, but it is closely related to this patch.
I have not reproduced it; so far this comes from reading the code. It
would need rx-gro-list on the relay's ingress device, and tx
checksumming plus tx-scatter-gather-fraglist on the amt device (all
three off by default), and a GRO aggregate that passes ipmr's DF/MTU
check. It predates this patch, and the cover letter already lists it as
not touched and untested. I will send a separate fix for it once I have
reproduced it.
next prev parent reply other threads:[~2026-10-04 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 21:24 [PATCH net-next v2 0/2] amt: mark relay data as a UDP tunnel packet, with a selftest Omar Ramadan
2026-10-02 21:24 ` [PATCH net-next v2 1/2] amt: mark relay data as a UDP tunnel packet before sending it Omar Ramadan
2026-10-03 21:49 ` netdev-bot+sashiko
2026-10-04 14:01 ` Omar Ramadan [this message]
2026-10-02 21:24 ` [PATCH net-next v2 2/2] selftests: net: add an amt test for UDP_SEGMENT through the relay Omar Ramadan
2026-10-03 21:49 ` netdev-bot+sashiko
2026-10-04 14:00 ` Omar Ramadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261004140123.94341-1-omar@blockcast.net \
--to=omar@blockcast.net \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®