From: Svyatoslav Ryhel <clamor95@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Svyatoslav Ryhel <clamor95@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mfd@lists.linux.dev
Subject: [PATCH v2 2/3] mfd: max8907: Remove platform_data based probing
Date: Sun, 4 Oct 2026 19:45:39 +0300 [thread overview]
Message-ID: <20261004164540.198446-3-clamor95@gmail.com> (raw)
In-Reply-To: <20261004164540.198446-1-clamor95@gmail.com>
There are no in-tree users of this driver, but it supports devicetree
based probing, which means external dtb files may exist that work with
this.
Remove the unused legacy code and make this a DT-only driver.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/mfd/max8907.c | 8 +-------
drivers/regulator/max8907-regulator.c | 8 +++-----
include/linux/mfd/max8907.h | 5 -----
3 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index 7bac1d6517717..363ac80c0593b 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -184,13 +184,7 @@ static int max8907_i2c_probe(struct i2c_client *i2c)
{
struct max8907 *max8907;
int ret;
- struct max8907_platform_data *pdata = dev_get_platdata(&i2c->dev);
- bool pm_off = false;
-
- if (pdata)
- pm_off = pdata->pm_off;
- else if (i2c->dev.of_node)
- pm_off = of_property_read_bool(i2c->dev.of_node,
+ bool pm_off = of_property_read_bool(i2c->dev.of_node,
"maxim,system-power-controller");
max8907 = devm_kzalloc(&i2c->dev, sizeof(struct max8907), GFP_KERNEL);
diff --git a/drivers/regulator/max8907-regulator.c b/drivers/regulator/max8907-regulator.c
index e59aa7a3ee546..907ed3fca5e97 100644
--- a/drivers/regulator/max8907-regulator.c
+++ b/drivers/regulator/max8907-regulator.c
@@ -274,7 +274,6 @@ static inline struct device_node *match_of_node(int index)
static int max8907_regulator_probe(struct platform_device *pdev)
{
struct max8907 *max8907 = dev_get_drvdata(pdev->dev.parent);
- struct max8907_platform_data *pdata = dev_get_platdata(max8907->dev);
int ret;
struct max8907_regulator *pmic;
unsigned int val;
@@ -312,10 +311,9 @@ static int max8907_regulator_probe(struct platform_device *pdev)
struct regulator_dev *rdev;
config.dev = pdev->dev.parent;
- if (pdata)
- idata = pdata->init_data[i];
- else
- idata = match_init_data(i);
+
+ idata = match_init_data(i);
+
config.init_data = idata;
config.driver_data = pmic;
config.regmap = max8907->regmap_gen;
diff --git a/include/linux/mfd/max8907.h b/include/linux/mfd/max8907.h
index 4be3c2370e2a4..e222250f0cc1e 100644
--- a/include/linux/mfd/max8907.h
+++ b/include/linux/mfd/max8907.h
@@ -227,11 +227,6 @@ enum {
MAX8907_IRQ_RTC_ALARM0,
};
-struct max8907_platform_data {
- struct regulator_init_data *init_data[MAX8907_NUM_REGULATORS];
- bool pm_off;
-};
-
struct regmap_irq_chips_data;
struct max8907 {
--
2.53.0
next prev parent reply other threads:[~2026-10-04 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 16:45 [PATCH v2 0/3] mfd: max8907: Schema, pdata and poweroff Svyatoslav Ryhel
2026-10-04 16:45 ` [PATCH v2 1/3] regulator: dt-bindings: maxim,max8907: Convert to DT schema Svyatoslav Ryhel
2026-10-05 13:30 ` Rob Herring (Arm)
2026-10-04 16:45 ` Svyatoslav Ryhel [this message]
2026-10-04 16:45 ` [PATCH v2 3/3] mfd: max8907: Convert to use device managed poweroff handler Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261004164540.198446-3-clamor95@gmail.com \
--to=clamor95@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®