From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv2-f43.google.com (mail-qv2-f43.google.com [74.125.230.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD419480335 for ; Sun, 4 Oct 2026 18:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791137407; cv=none; b=dQfGF+GSsT7+qB6NBdjiJLv4wrvghaYILN4q1sW+Gwi2iSD4U0FDygE3KoOGK35VSsb1vKIpl7vfWX6U4uqqiXBK6B1R1KeZAyU+7saqJ2jvN9qnJgYfWPfOIgCdcQExQ8h76bVLdnuBTReEETLPMFpf+hfVooqqAlDqJghZO0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791137407; c=relaxed/simple; bh=oJdXiqd2wc6WPYn9cOVUlqBNnR5Q2SQg7rjq/NYDxsI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=d5eVl4Z9I8IZia6LfFn/gSfdkFOoG5X55u46K4f0uPSD+WSKsnmOcuvKKAspzrxvn2vmZb2DYBCpbKYoR1Kk2xWU2xDa0frDu3/Cdd/4TvYTOXHwBdScAr1nwFnLTcJox+pTdtwVed7hBT18MbPbQQ8y2E2m5Durm4AzQI93zYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BBKK/rUn; arc=none smtp.client-ip=74.125.230.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BBKK/rUn" Received: by mail-qv2-f43.google.com with SMTP id 6a1803df08f44-91951457245so11969716d6.2 for ; Sun, 04 Oct 2026 11:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791137402; x=1791742202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XN2y9HoEh/B+DkH2/LgEo5mNVmafbb4PxYEtM4F0P2g=; b=BBKK/rUnyef/aM1adxc7n0qzJ17kXDqTSv8X5y32zPxHs2VdAwQ8wcDcs6EX6X0OlL xj/SddChxyNDvGVp9NdHUcinL/bmIgF5qieT7sOw5QNnwtBtXFZxfq+NN/97Q8TVpXJd v3bZ74TyJyCDtF3gkS17xUUrhU0zzIgnIz8kr6opKoVAcGcxy0hju5GY7hPP7g1xiNZq E874Z75WTFViVcOhA+XH97ym59BuIpXyNJnyGIu3xvQ8ESF5CijMdlxKI2enx4lPDYoF 5qiSiTZlT66NxBLmnAHqFQIpYHRlVb5nZKx3Y0Fq6hr2aqzE8lQOiKCKz7AP7Pl1Wfps fE+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791137402; x=1791742202; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XN2y9HoEh/B+DkH2/LgEo5mNVmafbb4PxYEtM4F0P2g=; b=UqmfrYNi8SDfYHxBYtQ5VlZf2YS8kmHJ82kAHNjucKSbNGwVhtzBGcH9ezQi0MEJU4 jtsCRQKX2kmiROSVsbxfeF7ksM/DFnrvtUf8xPPNwTh2biHYrEIzoGPEUIfYCdeMUWbR +V3AR+brBtH5w8H374oLgM9xqCIwQr1VbiKQkmOn/mslAUUMM5RghgigF2XqMf0opB9j iZyYhv9OzmvnQIGxIyv+oUawDqulYcbD61Yo4wt3uC9D8iYwf7PVHSNqNw1GyDG7uNb1 Pj5T5YdBe47HLgQPDJmKC4a9zmtjZVEByi1YHF0MPhCheU7fFdxTh5t5KGDUzEuOjDV7 DM5Q== X-Forwarded-Encrypted: i=1; AKwUvBzKy7osGsGSVudXC2SUOWMAYnJlhjqBGmbC7QZDS8hyLpyoSduITIJsjVWedSdAce81cYdqR6KQrM/n9TQ=@vger.kernel.org X-Gm-Message-State: AFuF++mlXU2KA1FkxuNhJKFtk4kli4TFp0sk5zY1BKp8f0Fc3tPnHKqP 8UcPk5z1VTYC7xTmmjfE1oeepAuSzxtewnPIAsoDVn8xRzm2TLbP8S9U X-Gm-Gg: AYBFou0KF3+wyT1oV3/ZR0zUfqGnd1I98alDdSrEdYVlV3E5rvFgcD8FtOCEdvjRxiA NQeiMQ90QziOMgt5V58qesllcOt0cksf1OIgcrN0GzmKaXwPowH/eRTn5TDfreRSm5Kt8lyKY9z UGsuwWULbW7KsvnRxCQgUKYuYVbiUDkdUaT6B0AbsfKri0cPCY7OzODQZ7Y/oXd0f1A7ehSGTGM UakTBBHZAaw2+5+2jyggJAxytqXOX488VvKsQWJ28AHYyokfG9w/9Ij0Mmc2u+gkTrj8HhS9fRE IpNROAGHiF/s6zlK1Fw+KP6ldOgGxI9oJ7qtlhRmWGpNkVKy2R7PMGD5JqGQg9z5StsIo/elwIB V5YxOc//aiy8eTGWLXnFcBfVvgLQtnFODSPFUIWuSa+T3JHU8fuHSpbzLBnpjR0wM9cocVQvjSq pdHWPo5Vfr8b2C7B+hUTVNITOd3QWOklM3OtcJohU7oB6Rejvx1M+S0Ll017ccapJ6lSW3z6K1L oY2QFaCMKY2dlWwnUAIgWzIo+k+M6Sz X-Received: by 2002:a05:6214:8593:10b0:912:517b:40e5 with SMTP id 6a1803df08f44-917c01931a7mr120128746d6.44.1791137402128; Sun, 04 Oct 2026 11:10:02 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-917d593b181sm70354166d6.6.2026.10.04.11.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 11:10:01 -0700 (PDT) From: Yuho Choi To: Tony Nguyen , Przemek Kitszel Cc: Simon Horman , Alexander Lobakin , Joshua Hay , Alan Brady , Sridhar Samudrala , Phani Burra , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH net v2] idpf: Fix vport IRQ name leak on request failure Date: Sun, 4 Oct 2026 14:08:39 -0400 Message-ID: <20261004180954.163789-1-oss.patchbox@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit idpf_vport_intr_req_irq() allocates a name for each vector IRQ before calling request_irq(). On success, the name is released later through kfree(free_irq()), but when request_irq() fails, the error path only unwinds the previous vectors and the name for the failed one is leaked. Free the allocated name on the request_irq() failure path, as done for the mailbox IRQ in commit 9bff30482c10 ("idpf: Fix mailbox IRQ name leak on request failure"). While at it, fail with -ENOMEM when the name cannot be allocated instead of requesting the IRQ without a name. Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") Signed-off-by: Yuho Choi --- Changes in v2: - Correct the Fixes: tag (Simon Horman) - Handle kasprintf() failure (Simon Horman) v1: https://lore.kernel.org/all/20260923234819.702327-1-oss.patchbox@gmail.com/ Compile-tested only (x86_64 defconfig + CONFIG_IDPF=m, W=1). drivers/net/ethernet/intel/idpf/idpf_txrx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c index 4311ffa30bb1..af3213eae393 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c @@ -4067,12 +4067,17 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport, name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name, vec_name, vector); + if (!name) { + err = -ENOMEM; + goto free_q_irqs; + } err = request_irq(irq_num, idpf_vport_intr_clean_queues, 0, name, q_vector); if (err) { netdev_err(vport->netdev, "Request_irq failed, error: %d\n", err); + kfree(name); goto free_q_irqs; } base-commit: 551c722f40809618230001baccf219193e22fc5a -- 2.43.0