Re: [PATCH net-next] net: stmmac: mask the MAC interrupt while resume resets the MAC

[Igor Velkov <iav@iav.lv>]

On Sun, Oct 04, 2026 at 04:42:23PM +0200, Andrew Lunn wrote:
> Is probe written this way? Does the needed code already exists, its
> just not used on resume when it should be?

Open is, by ordering: __stmmac_open() calls stmmac_hw_setup(), which
does the reset, and only then stmmac_request_irq(). stmmac_release()
frees the line again. MTU change, the ethtool ring and channel changes
and the reset subtask all go through release and open, so they get the
same ordering.

Resume is the only other caller of stmmac_hw_setup(), and the only one
that resets with the handler installed: nothing in suspend frees or
disables the line. The PM core disables it for the noirq phase only;
dpm_resume_noirq() enables it again before stmmac_resume() runs.

So there is no helper to reuse, only that ordering. The patch gives
resume the same with disable_irq()/enable_irq() instead of
free_irq()/request_irq().

--
Igor Velkov