mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: linux-bcache@vger.kernel.org
Cc: Coly Li <colyli@fygo.io>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] bcache: fix kernel-doc warning on CLOSURE_CALLBACK
Date: Sun,  4 Oct 2026 16:35:23 -0700	[thread overview]
Message-ID: <20261004233523.516891-1-rosenp@gmail.com> (raw)

bch_data_insert() is defined through the CLOSURE_CALLBACK() macro, which
kernel-doc cannot see through, so the kernel-doc comment above it
produces:

  request.c:308 function parameter 'bch_data_insert' not described in 'CLOSURE_CALLBACK'
  request.c:308 expecting prototype for bch_data_insert(). Prototype was for CLOSURE_CALLBACK() instead

Turn it into a regular block comment, and drop the @cl line along
with the kernel-doc markup.

Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/md/bcache/request.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index 3fa3b13a410f..e7f097346d64 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -285,9 +285,8 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
 	}
 }
 
-/**
+/*
  * bch_data_insert - stick some data in the cache
- * @cl: closure pointer.
  *
  * This is the starting point for any data to end up in a cache device; it could
  * be from a normal write, or a writeback write, or a write to a flash only
-- 
2.56.0


                 reply	other threads:[~2026-10-04 23:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261004233523.516891-1-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=colyli@fygo.io \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®