mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wayne Ho <wayneho219@gmail.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Griffin Kroah-Hartman <griffin@kroah.com>
Subject: [PATCH v2 0/2] Documentation: ABI: leds: Document shared trigger attributes
Date: Mon, 05 Oct 2026 23:27:45 +0800	[thread overview]
Message-ID: <20261005-docs-leds-abi-trigger-attrs-v2-0-c5f8970b1b42@gmail.com> (raw)

The delay_on, delay_off and invert attributes are created by several
LED triggers, but only the oneshot variants are documented. Adding a
separate ABI file per trigger would make get_abi.py report the same
sysfs path as defined more than once, so patch 2 moves these entries
to sysfs-class-led and describes each trigger's behaviour there.

Patch 1 is a small preparatory fix: the existing inverted entry still
mentions the gpio trigger, which no longer creates that attribute.

Checked with tools/docs/get_abi.py validate (no new warnings) and
scripts/checkpatch.pl (clean).

Signed-off-by: Wayne Ho <wayneho219@gmail.com>
---
Changes in v2:
- Capitalize the description after the subject prefix, and reword
  patch 1's subject to start with a verb (Sashiko)
- Add Fixes tag to patch 1 and reference the commit that removed the
  attribute (Griffin)
- Link to v1: https://patch.msgid.link/20261001-docs-leds-abi-trigger-attrs-v1-0-54f0529bf0f6@gmail.com

---
Wayne Ho (2):
      Documentation: ABI: leds: Drop stale gpio trigger reference for inverted
      Documentation: ABI: leds: Document timer, heartbeat and activity attributes

 Documentation/ABI/testing/sysfs-class-led          | 73 +++++++++++++++++++++-
 .../ABI/testing/sysfs-class-led-trigger-oneshot    | 29 ---------
 2 files changed, 70 insertions(+), 32 deletions(-)
---
base-commit: 5dd1818b15d98d4a20806cd00b1b40320b06004f
change-id: 20261001-docs-leds-abi-trigger-attrs-a20ed96981dd

Best regards,
--  
Wayne Ho <wayneho219@gmail.com>


             reply	other threads:[~2026-10-05 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 15:27 Wayne Ho [this message]
2026-10-05 15:27 ` [PATCH v2 1/2] Documentation: ABI: leds: Drop stale gpio trigger reference for inverted Wayne Ho
2026-10-05 15:27 ` [PATCH v2 2/2] Documentation: ABI: leds: Document timer, heartbeat and activity attributes Wayne Ho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005-docs-leds-abi-trigger-attrs-v2-0-c5f8970b1b42@gmail.com \
    --to=wayneho219@gmail.com \
    --cc=griffin@kroah.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®